Review main Merged Breaking

93065[!!!][TASK] Remove obsolete pages-only new record route

Tobias Wojtylak CR +2 V +2 Hard +211 −611 updated 06/12/26, 10:28

Commit message

The page creation wizard introduced with #108915 superseded
the legacy "pages only" position selection flow of the records
module. The patch removes its now unused predecessors: the
db_new_pages route with its NewRecordController::newPageAction()
and NewRecord/NewPagePosition template, and the internal
PagePositionMap class.

The page TSconfig option
`mod.wizards.newRecord.pages.show.pageSelectPosition` is
documented to no longer have any effect.

With `newPageAction()` gone, `db_new` is the controller's only
entry point. The patch takes the opportunity to turn the class
into a stateless, `final readonly` service: Two main worker
methods are inlined to mainAction(), helpers receive additional
arguments. The main method looks a bit longish and still messy
now, but the patch's goal is to keep the change reviewable - it
is a good base to look at improved view separation and code
grouping with another step which will reduce the method again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 2642

Show 917 earlier messages
  1. Tobias Wojtylak uploaded patch set 1 03/04/26, 14:26

  2. Tobias Wojtylak uploaded patch set 2 03/04/26, 14:39

  3. core-ci voted on patch set 1 V -1 03/04/26, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97331

  4. core-ci voted on patch set 2 V -1 03/04/26, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97333

  5. Tobias Wojtylak rebased onto patch set 3 V -1 03/04/26, 15:43

  6. core-ci voted on patch set 3 V -1 03/04/26, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97339

  7. Tobias Wojtylak uploaded patch set 4 V -1 03/05/26, 08:19

  8. core-ci voted on patch set 4 V -1 03/05/26, 08:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97390

  9. Tobias Wojtylak rebased onto patch set 5 V -1 03/05/26, 09:03

  10. core-ci voted on patch set 5 V -1 03/05/26, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97394

  11. Tobias Wojtylak rebased onto patch set 6 V -1 03/06/26, 08:30

  12. core-ci voted on patch set 6 V -1 03/06/26, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97471

  13. Tobias Wojtylak rebased onto patch set 7 V -1 03/10/26, 07:24

  14. core-ci voted on patch set 7 V -1 03/10/26, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97652

  15. Tobias Wojtylak rebased onto patch set 8 V -1 03/10/26, 09:25

  16. core-ci voted on patch set 8 V -1 03/10/26, 09:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97658

  17. Tobias Wojtylak rebased onto patch set 9 V -1 03/10/26, 09:41

  1. core-ci voted on patch set 9 V -1 03/10/26, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97662

  2. Tobias Wojtylak uploaded patch set 10 V -1 03/23/26, 08:27

  3. core-ci voted on patch set 10 V -1 03/23/26, 08:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98432

  4. Tobias Wojtylak marked it ready for review 03/23/26, 10:47

  5. Tobias Wojtylak marked it work in progress 03/23/26, 10:48

  6. Tobias Wojtylak rebased onto patch set 11 V -1 03/24/26, 10:33

  7. core-ci voted on patch set 11 V -1 03/24/26, 10:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98568

  8. Tobias Wojtylak rebased onto patch set 12 V -1 03/24/26, 15:42

  9. core-ci voted on patch set 12 V -1 03/24/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98612

  10. Tobias Wojtylak uploaded patch set 13 V -1 03/25/26, 16:00

  11. core-ci voted on patch set 13 V +1 03/25/26, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98709

  12. Tobias Wojtylak uploaded patch set 14 V +1 03/25/26, 16:17

  13. core-ci voted on patch set 14 V +1 03/25/26, 16:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98711

  14. Tobias Wojtylak uploaded patch set 15 V +1 03/30/26, 08:52

  15. core-ci voted on patch set 15 V +1 03/30/26, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99017

  16. Tobias Wojtylak marked it ready for review 03/30/26, 09:24

  17. Benni Mack updated the commit message in patch set 16 V +1 04/22/26, 07:28

  18. Christian Kuhn commented on patch set 16 06/11/26, 14:22

    let's get this done, the route is still unused. i'll re-scope main-only (does not harm much in v14), and will clean up that messy controller along the way for easy going when its touched next time.
  19. Christian Kuhn uploaded patch set 17 06/11/26, 14:26

  20. core-ci voted on patch set 17 V +1 06/11/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103407

  21. Christian Kuhn voted on patch set 17 CR +1 06/11/26, 14:38

  22. Stefan Bürk voted on patch set 17 CR +1 06/11/26, 16:10

  23. Stefan Bürk voted on patch set 17 V +1 06/11/26, 16:14

  24. Christian Kuhn voted on patch set 17 CR +2 V +2 06/12/26, 10:27

  25. Christian Kuhn merged patch set 18 06/12/26, 10:28