Review main Merged

93067[TASK] Migrate EXT:form from jQuery to Vanilla JS - Replace $.type()

Josua Vogel CR +2 V +2 Normal +108 −108 updated 03/11/26, 20:55

Commit message

Replace all usages of the deprecated jQuery `$.type()` utility
with native JavaScript type checks across the form editor
TypeScript sources.

Applied migration rules:

  'object' === $.type(x)
    => typeof x === 'object' && x !== null && !Array.isArray(x)
  'object' !== $.type(x)
    => typeof x !== 'object' || x === null || Array.isArray(x)
  'array' === $.type(x)
    => Array.isArray(x)
  'string' === $.type(x)
    => typeof x === 'string'
  'undefined' === $.type(x)
    => typeof x === 'undefined'
  'null' !== $.type(x)
    => x !== null

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1014

  1. Josua Vogel uploaded patch set 1 03/04/26, 15:22

  2. core-ci voted on patch set 1 V +1 03/04/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97335

  3. Benjamin Franzke commented on patch set 1 03/05/26, 04:18

    lookks good so far, but we need a ticket number here ;)
  4. Josua Vogel updated the commit message in patch set 2 V +1 03/05/26, 21:02

  5. Josua Vogel commented on patch set 2 03/05/26, 21:03

    Reply

    Done
  6. Josua Vogel uploaded patch set 3 03/05/26, 21:07

  7. core-ci voted on patch set 2 V +1 03/05/26, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97440

  8. core-ci voted on patch set 3 V +1 03/05/26, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97441

  9. Georg Ringer voted on patch set 3 CR +1 V +1 03/06/26, 09:32

  10. Josua Vogel uploaded patch set 4 CR +1 V +1 03/11/26, 09:21

  11. core-ci voted on patch set 4 V +1 03/11/26, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97743

  12. Sven Liebert voted on patch set 4 CR +1 V +1 03/11/26, 20:37

  13. Benni Mack voted on patch set 4 CR +2 V +2 03/11/26, 20:55

  14. Benni Mack merged patch set 5 03/11/26, 20:55