Review main Merged

93074[TASK] Fix wrong case of method name

Simon Schaufelberger CR +2 V +2 Easy +2 −2 updated 03/04/26, 21:40

Commit message

The method call $this->getLanguageService()->sl() must be written as
$this->getLanguageService()->sL()

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Josua Vogel +1

Issues 1

Files 1

Review log 1113

  1. Simon Schaufelberger uploaded patch set 1 03/04/26, 20:55

  2. Garvin Hicking commented on patch set 1 03/04/26, 20:58

    Would you be fine to label this a task? It's more a typo that has no functional effect right?
  3. Georg Ringer voted on patch set 1 CR +1 V +1 03/04/26, 20:59

  4. Simon Schaufelberger commented on patch set 1 03/04/26, 21:00

    Reply

    i really don't care. PHP is broken by design that it doesn't care about wrong casing.
  5. Christian Kuhn voted on patch set 1 CR +1 V +1 03/04/26, 21:03

  6. core-ci voted on patch set 1 V +1 03/04/26, 21:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97362

  7. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 03/04/26, 21:04

  8. Garvin Hicking commented on patch set 2 CR +1 V +1 03/04/26, 21:04

    Reply

    Acknowledged
  9. Anja Leichsenring voted on patch set 2 CR +1 V +1 03/04/26, 21:05

  10. Josua Vogel voted on patch set 2 CR +1 V +1 03/04/26, 21:08

  11. Georg Ringer voted on patch set 2 CR +2 V +2 03/04/26, 21:08

  12. Georg Ringer merged patch set 3 03/04/26, 21:08

  13. core-ci voted on patch set 2 V +1 03/04/26, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97363