Review main Merged

93075[BUGFIX] Preserve defVals through record_edit redirect cycle

Oli Bartsch CR +2 V +2 Easy +1 −0 updated 03/04/26, 22:14

Commit message

The backend JavaScript router strips the CSRF token
from the browser URL bar via history.replaceState
for cleaner URLs. When the user reloads the page,
the request arrives without a token, triggering
a MissingRequestTokenException. The resulting
redirect through RouteRedirect filters query
parameters to a whitelist, which did not include
`defVals`. This caused default values like
`redirect_type` to be lost, breaking new record
forms that depend on them (e.g. QR codes or Short URLs).

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 03/04/26, 21:06

  2. core-ci voted on patch set 1 V +1 03/04/26, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97364

  3. Jochen Roth voted on patch set 1 CR +1 V +1 03/04/26, 21:16

  4. Georg Ringer voted on patch set 1 CR +1 V +1 03/04/26, 21:34

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 03/04/26, 22:14

  6. Oli Bartsch merged patch set 2 03/04/26, 22:14