Review main Merged

93078[TASK] Migrate EXT:form from jQuery to Vanilla JS - fadeOut()/fadeIn()

Josua Vogel CR +2 V +2 Normal +27 −91 updated 03/10/26, 12:57

Commit message

Remove all jQuery `.fadeOut()` and `.fadeIn()` calls and the
associated `useFadeEffect` / `toolbarUseFadeEffect` parameters from
the form editor modules. The fade animations were purely cosmetic
and introduced unnecessary async callback chains that complicated
the code and could cause race conditions on rapid clicks.

All rendering now executes synchronously without animation. The
conditional `if (useFadeEffect) { ... } else { ... }` blocks have
been collapsed to always use the direct (non-animated) code path.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Josua Vogel uploaded patch set 1 03/05/26, 07:32

  2. core-ci voted on patch set 1 V +1 03/05/26, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97388

  3. Josua Vogel updated the commit message in patch set 2 V +1 03/06/26, 14:14

  4. core-ci voted on patch set 2 V +1 03/06/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97514

  5. Josua Vogel uploaded patch set 3 V +1 03/07/26, 10:55

  6. core-ci voted on patch set 3 V +1 03/07/26, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97548

  7. Benni Mack voted on patch set 3 CR +1 V +1 03/10/26, 12:21

  8. Georg Ringer voted on patch set 3 CR +2 V +2 03/10/26, 12:57

  9. Georg Ringer merged patch set 4 03/10/26, 12:57