Review main Merged

93079[TASK] Enrich password generation failed message

Riccardo De Contardi CR +2 V +2 Easy +1 −1 updated 08/24/26, 20:50

Commit message

Add some help for the user to the error message for failed password
generation

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Josef Glatz +1
    • Oliver Klee +1
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1315

  1. Riccardo De Contardi uploaded patch set 1 03/05/26, 09:23

  2. Simon Schaufelberger voted on patch set 1 CR +1 V +1 03/05/26, 09:28

  3. Mathias Brodala commented on patch set 1 03/05/26, 09:30

    locallang_core.xlf:538

    I understand the intention UX-wise but this change does not really add much. The password generator should actually be extended to output existing error messages and mention them here. After this we'll have a system admin which is grateful for the error details. ;-)
  4. Riccardo De Contardi commented on patch set 1 03/05/26, 09:37

    locallang_core.xlf:538 Reply

    I see your point... a longer message could be: "Password generation failed. This could be due to a misconfiguration issue; please check the Administration log for details or contact your system administrator."
  5. core-ci voted on patch set 1 V +1 03/05/26, 09:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97397

  6. Mathias Brodala commented on patch set 1 CR -1 03/05/26, 09:40

    locallang_core.xlf:538 Reply

    Yes, that would be an improvement given the current state. Can you extend the message accordingly?
  7. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 07:27

  8. Simon Schaufelberger uploaded patch set 3 06/16/26, 22:03

  9. Simon Schaufelberger commented on patch set 3 CR +1 V +1 06/16/26, 22:03

    locallang_core.xlf:538 Reply

    Done
  10. core-ci voted on patch set 3 V +1 06/16/26, 22:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103582

  11. Josua Vogel voted on patch set 3 CR +1 V +1 06/17/26, 06:09

  12. Oliver Klee voted on patch set 3 CR +1 V +1 06/17/26, 09:49

  13. Josef Glatz voted on patch set 3 CR +1 V +1 06/17/26, 10:03

  14. Benjamin Kott voted on patch set 3 CR +2 V +2 08/24/26, 20:40

  15. Benjamin Kott merged patch set 4 08/24/26, 20:50