Review main Merged

93081[BUGFIX] Forms Wizard: Auto-focus `newFormName` in settings step

Tobias Wojtylak CR +2 V +2 Easy +15 −8 updated 03/06/26, 07:22

Commit message

Ensure that the `newFormName` text input field in the Forms Wizard
Settings step receives focus automatically when the step is opened.

Replace `@change` with `@input` event listener to handle updates
immediately as the user types for `newFormName` text input field

Remove duplicate `await` in localization-submission-service

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 67

  1. Tobias Wojtylak uploaded patch set 1 03/05/26, 10:45

  2. core-ci voted on patch set 1 V +1 03/05/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97404

  3. Josua Vogel commented on patch set 1 03/05/26, 11:22

    Just a quick question: Would it be appropriate to always focus on the first interactive element in the wizards?
  4. Tobias Wojtylak commented on patch set 1 03/05/26, 13:18

    Reply

    Thanks for your review. I understand your point. Of course we could solve it that way as well — the question is whether that’s really the intended behavior. For example, with the modes the first is already preselected. You would first have to jump from the options to the Next button (especially when using keyboard navigation) in order to continue. It could be similar when selecting `predefined` in the form wizard. There might be multiple input fields that are already prefilled e.g. prototype and therefore already contain valid values. I’m not completely happy with this solution either — it’s more of a workaround because the steps are not Lit elements and therefore don’t have a lifecycle. An alternative approach might be to dispatch events when switching steps, or to introduce another step interface, something like WizardFocusableStep, which defines a selector (as a property). That element could then be selected after rendering.
  5. Josua Vogel commented on patch set 1 CR +1 V +1 03/05/26, 17:55

    Reply

    Okay, I was just curious :) The current patch looks good to me. No need to overcomplicate
  6. Georg Ringer voted on patch set 1 CR +2 V +2 03/06/26, 07:22

  7. Georg Ringer merged patch set 2 03/06/26, 07:22