93085[TASK] Refactor field items processing into dedicated service
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 2
Files 13
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+14 −21
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+8 −190
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCategory.php+10 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaCountry.php+7 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaLanguage.php+7 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+8 −14
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php+38 −10
- typo3/sysext/backend/Classes/Form/Processor/TcaFieldItemsConfigurationProcessor.phpnew+255 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+13 −25
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCountryTest.php+9 −6
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+70 −286
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectTreeItemsTest.php+6 −18
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php+33 −22
Review log 1219
-
Tobias Wojtylak uploaded patch set 1 03/05/26, 15:17
-
core-ci voted on patch set 1 V -1 03/05/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97418
-
Tobias Wojtylak uploaded patch set 2
V -103/05/26, 15:48 -
core-ci voted on patch set 2 V -1 03/05/26, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97420
-
Tobias Wojtylak uploaded patch set 3
V -103/05/26, 17:06 -
core-ci voted on patch set 3 V -1 03/05/26, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97427
-
Benjamin Franzke commented on patch set 3 03/06/26, 07:34
-
Tobias Wojtylak uploaded patch set 4
V -103/06/26, 09:04 -
Tobias Wojtylak uploaded patch set 5 03/06/26, 09:53
-
core-ci voted on patch set 4 V -1 03/06/26, 10:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97472
-
core-ci voted on patch set 5 V -1 03/06/26, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97478
-
Tobias Wojtylak uploaded patch set 6
V -103/06/26, 10:39 -
core-ci voted on patch set 6 V +1 03/06/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97482
-
Tobias Wojtylak marked it ready for review 03/06/26, 10:52
-
Tobias Wojtylak commented on patch set 6 03/06/26, 10:55
Unresolved
TBD: Naming, Reset Handling in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php#L77 General Handling in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php#L116 https://github.com/TYPO3/typo3/blob/main/typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectTreeItems.php#L160 -
Josua Vogel updated the commit message in patch set 7
V +103/06/26, 10:57 -
core-ci voted on patch set 7 V +1 03/06/26, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97487
-
Tobias Wojtylak marked it work in progress 03/12/26, 14:58
-
Christian Kuhn abandoned the change 03/13/26, 08:36
abandoning in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/93139
Unresolved