Review main Merged

93087[BUGFIX] Fire somePropertyChanged event for defaultValue in PropertyGridEditor

Josua Vogel CR +2 V +2 Easy +12 −4 updated 11/13/26, 09:34

Commit message

When toggling the "Selected" checkbox in the PropertyGridEditor
(used by MultiCheckbox, MultiSelect, RadioButton, SingleSelect),
the `core/formElement/somePropertyChanged` event was incorrectly
fired for `properties.options` instead of `defaultValue`.

This happened due to three issues:

1. The `defaultValue` property had no registered publisher topic
   on the form element model, so `set('defaultValue', ...)` could
   never publish any event.

2. For single-selection elements, the `set()` call for
   `defaultValue` explicitly passed `disablePublishersOnSet: true`,
   suppressing event publishing even if a topic had been registered.

3. The `set()` call for `properties.options` was executed
   unconditionally on every change, even when only the selection
   state changed and the options data remained identical. This
   caused a misleading `somePropertyChanged` event with
   `propertyPath: properties.options` and identical old/new values.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1017

  1. Josua Vogel uploaded patch set 1 03/05/26, 16:58

  2. Josua Vogel updated the commit message in patch set 2 03/05/26, 16:58

  3. core-ci voted on patch set 1 V +1 03/05/26, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97423

  4. core-ci voted on patch set 2 V +1 03/05/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97424

  5. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 06:41

  6. core-ci voted on patch set 3 V -1 04/22/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100765

  7. Josua Vogel uploaded patch set 4 V -1 04/23/26, 08:57

  8. core-ci voted on patch set 4 V +1 04/23/26, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101011

  9. Josua Vogel uploaded patch set 5 V +1 09/24/26, 14:12

  10. core-ci voted on patch set 5 V +1 09/24/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109164

  11. Josua Vogel rebased onto patch set 6 V +1 09/30/26, 20:30

  12. core-ci voted on patch set 6 V +1 09/30/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109703

  13. Georg Ringer uploaded patch set 7 V +1 11/12/26, 22:36

  14. Georg Ringer voted on patch set 7 CR +1 V +1 11/12/26, 22:37

  15. core-ci voted on patch set 7 V +1 11/12/26, 22:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114252

  16. Benni Mack voted on patch set 7 CR +2 V +2 11/13/26, 09:34

  17. Benni Mack merged patch set 8 11/13/26, 09:34