Review main Merged

93091[FEATURE] Improved exceptions in Fluid templates

Simon Praetorius CR +2 V +2 Normal +167 −83 updated 03/13/26, 09:34

Commit message

Changes in exception handling within Fluid Standalone allows us to
improve exception messages that result from Fluid templates. Most
importantly, almost all exceptions now contain the full path to the
affected template file, which should simplify debugging significantly.

This patch streamlines exception usage across ViewHelpers in TYPO3
Core that are part of the supported API (EXT:fluid, EXT:core,
EXT:backend, EXT:form). In places where the template parser is used
directly, the original template path is provided to make these better
exception messages possible everywhere.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Christian Kuhn +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Christian Kuhn +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 1625

  1. Simon Praetorius uploaded patch set 1 03/05/26, 18:51

  2. core-ci voted on patch set 1 V -1 03/05/26, 19:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97432

  3. Simon Praetorius uploaded patch set 2 V -1 03/10/26, 20:11

  4. Simon Praetorius uploaded patch set 3 03/10/26, 20:34

  5. core-ci voted on patch set 2 V -1 03/10/26, 20:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97716

  6. Simon Praetorius uploaded patch set 4 03/10/26, 21:00

  7. core-ci voted on patch set 3 V -1 03/10/26, 21:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97719

  8. core-ci voted on patch set 4 V -1 03/10/26, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97722

  9. Simon Praetorius uploaded patch set 5 V -1 03/10/26, 21:27

  10. core-ci voted on patch set 5 V -1 03/10/26, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97723

  11. core-ci commented on patch set 5 03/10/26, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97723

  12. Simon Praetorius uploaded patch set 6 V -1 03/11/26, 11:46

  13. core-ci voted on patch set 6 V -1 03/11/26, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97751

  14. Simon Praetorius uploaded patch set 7 V -1 03/11/26, 12:45

  15. Simon Praetorius marked it ready for review 03/11/26, 12:45

  16. core-ci voted on patch set 7 V +1 03/11/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97758

  17. Simon Schaufelberger commented on patch set 7 03/11/26, 19:03

    Feature-109167-ImprovedExceptionsInFluidTemplates.rst:29

    `php` or `php-short` - that is the question...
  18. Simon Praetorius uploaded patch set 8 V +1 03/12/26, 11:36

  19. Simon Praetorius commented on patch set 8 03/12/26, 11:36

    Feature-109167-ImprovedExceptionsInFluidTemplates.rst:29 Reply

    Thx, switched it to `:php:` to avoid namespace confusion.
  20. core-ci voted on patch set 8 V +1 03/12/26, 11:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97822

  21. Simon Schaufelberger voted on patch set 8 CR +1 V +1 03/12/26, 12:26

  22. Christian Kuhn voted on patch set 8 CR +1 V +1 03/12/26, 22:27

  23. Matthias Vogel voted on patch set 8 CR +1 V +1 03/13/26, 05:33

  24. Simon Praetorius voted on patch set 8 CR +2 V +2 03/13/26, 09:34

  25. Simon Praetorius merged patch set 9 03/13/26, 09:34