93092[BUGFIX] Sync displayed HTTP status code with actual response header in ProductionExceptionHandler
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Markus Klein +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Markus Klein +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1620
-
Josua Vogel uploaded patch set 1 03/05/26, 19:01
-
core-ci voted on patch set 1 V +1 03/05/26, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97433
-
Garvin Hicking commented on patch set 1 03/14/26, 21:19
I have a small tingling feeling this might be better to do in main only...?ProductionExceptionHandler.php:154I feel like for BC of proxy/setup handling we should probably keep 503 as fallback instead of 500 here? -
Josua Vogel commented on patch set 2
V +103/16/26, 07:12Published edit on patch set 1. -
core-ci voted on patch set 2 V +1 03/16/26, 07:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97986
-
Josua Vogel commented on patch set 2 03/16/26, 07:25
Reply
DoneProductionExceptionHandler.php:154ReplyThat's fine with me -
Garvin Hicking voted on patch set 2 CR +1 V +1 03/16/26, 08:06
-
Markus Klein commented on patch set 2 03/16/26, 08:08
ProductionExceptionHandler.php:144that's wrong. 503 is returned insteadProductionExceptionHandler.php:148I'm not sure on this implementation way. yes, we duck-type in the other method as well; still not nice. On top we assume the status to be part of the first header. Is this always true?? The regex catches any 3-digit number somewhere in the header. -
Garvin Hicking voted on patch set 2 CR 0 V 0 03/16/26, 08:22
-
Josua Vogel uploaded patch set 3
V +105/22/26, 11:59 -
Josua Vogel commented on patch set 3 05/22/26, 12:00
ProductionExceptionHandler.php:144ReplyDoneProductionExceptionHandler.php:148ReplyDone -
core-ci voted on patch set 3 V -1 05/22/26, 12:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102351
-
Josua Vogel uploaded patch set 4
V -105/26/26, 05:30 -
core-ci voted on patch set 4 V +1 05/26/26, 05:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102427
-
Oliver Klee voted on patch set 4 CR +1 V +1 05/26/26, 07:01
-
Markus Klein voted on patch set 4 CR +1 V +1 05/26/26, 07:36
-
Christian Kuhn commented on patch set 4 05/28/26, 20:30
AbstractExceptionHandler.php:226this is ugly: the httpUtility constants should probably be backed enums with string value for the explanation and the 3 digit code, the exceptions should then carry that enum around. that's a topic for later, though. but it explains the need for this code. -
Stefan Bürk voted on patch set 4 CR +1 V +1 05/28/26, 20:38
-
Christian Kuhn voted on patch set 4 CR +2 V +2 05/28/26, 20:38
-
Christian Kuhn merged patch set 5 05/28/26, 20:46