93094[BUGFIX] Move #[RateLimit] and #[Authorize] resolution to compile time
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Garvin Hicking +1
- Torben Hansen +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/extbase/Classes/DependencyInjection/AuthorizePass.php2new+78 −0
- typo3/sysext/extbase/Classes/DependencyInjection/RateLimitPass.php2new+77 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+11 −31
- typo3/sysext/extbase/Classes/Mvc/Controller/AuthorizeRegistry.phpnew+61 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/RateLimitRegistry.phpnew+60 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Method.php+0 −17
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+0 −11
- typo3/sysext/extbase/Configuration/Services.php+2 −0
Review log 1215
-
Benni Mack uploaded patch set 1 03/05/26, 20:51
-
core-ci voted on patch set 1 V +1 03/05/26, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97438
-
Benni Mack updated the commit message in patch set 2
V +103/12/26, 07:46 -
Benni Mack marked it ready for review 03/12/26, 07:46
-
core-ci voted on patch set 2 V +1 03/12/26, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97797
-
Andreas Kienast commented on patch set 2 03/12/26, 08:58
RateLimitPass.php:31Class can be made `readonly`. -
Stefan Bürk uploaded patch set 3
V +103/12/26, 12:37 -
Stefan Bürk commented on patch set 3 03/12/26, 12:37
AuthorizePass.php:31ReplyDoneRateLimitPass.php:31ReplyDone -
core-ci voted on patch set 3 V +1 03/12/26, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97827
-
Garvin Hicking commented on patch set 3 03/12/26, 21:35
I'd rather label this as [TASK], yes? -
Torben Hansen voted on patch set 3 V +1 03/13/26, 07:03
-
Stefan Bürk voted on patch set 3 CR +1 V +1 03/13/26, 09:58
-
Garvin Hicking commented on patch set 3 CR +1 V +1 03/13/26, 12:36
Thanks for this effort. When reviewing both attribute-based patches I was already thinking about if runtime-analysis is the best thing, but then I thought it falls in line with the current process. But this approach is superior and paves a good way forward. -
Stefan Bürk voted on patch set 3 CR +2 V +2 03/13/26, 12:54
-
Stefan Bürk merged patch set 4 03/13/26, 12:54
AuthorizePass.php:31