Review main Merged

93097[TASK] Replace Bootstrap Tabs

Benjamin Kott CR +2 V +2 Expert +1187 −742 updated 03/18/26, 08:39

Commit message

Replaces Bootstrap's Tab JavaScript with a custom implementation
tailored for TYPO3 needs. The new module provides a declarative API
using `data-typo3-tab` attributes and a programmatic `Tab.show()`
method. This is part of the ongoing effort to remove Bootstrap
JavaScript dependencies from the TYPO3 backend.

The implementation handles ARIA attributes, keyboard navigation using
arrow keys, Home, and End, and dispatches `typo3:tab:show` and
`typo3:tab:shown` custom events. Backward-compatible `show.bs.tab` and
`shown.bs.tab` events are dispatched during v14 and deprecated for
removal in v15.

Tab overflow is now handled with scroll arrows instead of the previous
dropdown-based approach. The last active tab can be persisted via
BrowserSession when `data-store-last-tab` is present on the tablist.
Legacy `data-bs-toggle="tab"` markup is automatically migrated at
runtime, replacing `<a>` elements with `<button>` elements.

Modernizes the look and feel of all tabs in the backend and
consolidates all tab behavior into a single module. Updates the
styleguide tab examples with proper ARIA attributes and adds sections
for tab persistence and Bootstrap migration.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 3

Files 45

Show 25 more files

Review log 5069

Show 2844 earlier messages
  1. Benjamin Kott uploaded patch set 1 03/06/26, 00:51

  2. Benjamin Kott updated the commit message in patch set 2 03/06/26, 01:09

  3. Benjamin Kott updated the commit message in patch set 3 03/06/26, 01:10

  4. Benjamin Kott updated the commit message in patch set 4 03/06/26, 01:22

  5. core-ci voted on patch set 1 V -1 03/06/26, 01:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97448

  6. core-ci voted on patch set 4 V -1 03/06/26, 01:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97454

  7. core-ci voted on patch set 2 V -1 03/06/26, 01:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97452

  8. core-ci voted on patch set 3 V -1 03/06/26, 01:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97453

  9. Benjamin Kott uploaded patch set 5 V -1 03/06/26, 08:19

  10. core-ci voted on patch set 5 V -1 03/06/26, 08:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97468

  11. Benjamin Kott uploaded patch set 6 V -1 03/06/26, 09:35

  12. core-ci voted on patch set 6 V -1 03/06/26, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97476

  13. Benjamin Kott uploaded patch set 7 V -1 03/06/26, 12:19

  14. Benjamin Kott uploaded patch set 8 03/06/26, 12:20

  15. Benjamin Kott commented on patch set 8 03/06/26, 12:21

    This change is ready for review.
  16. Benjamin Kott uploaded patch set 9 03/06/26, 12:35

  17. Benjamin Kott uploaded patch set 10 03/06/26, 12:51

  18. core-ci voted on patch set 7 V -1 03/06/26, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97492

  19. core-ci voted on patch set 8 V -1 03/06/26, 12:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97493

  20. core-ci voted on patch set 9 V -1 03/06/26, 12:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97498

  21. Benjamin Kott uploaded patch set 11 03/06/26, 13:10

  22. core-ci voted on patch set 10 V -1 03/06/26, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97505

  23. core-ci voted on patch set 11 V -1 03/06/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97507

  24. Benjamin Kott uploaded patch set 12 V -1 03/06/26, 13:53

  25. core-ci voted on patch set 12 V +1 03/06/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97511

  26. Oli Bartsch commented on patch set 12 V -1 03/06/26, 16:23

    There is a design, which as been discussed and approved by us. It clearly uses a dropdown.
  27. Garvin Hicking commented on patch set 12 03/06/26, 19:06

    I generally like the idea to streamline this and make it more accessible. I would like to bring up the tabs for formengine like EXT:styleguide records "basic". I think in the "full view" I would really prefer a solution to have all possible tabs in sight so that I don't have to scroll through many tabs. Maybe we could, at least on TCA-level, have the opportunity to turn on "multiline mode" somehow for integration? I know the current solution looks really bad, but it allows to quickly access the tabs I need because I don't have to click multiple times and lead my head swirl because a whole row moves.
  28. Garvin Hicking commented on patch set 12 03/06/26, 19:06

    Reply

    unresolving
  29. Benjamin Kott commented on patch set 12 03/06/26, 23:51

    Reply

    The current solution has several problems; the display is only one of it. We had postponed this for a while since there was no clear preference/solution developed yet. But the introduction of the context-editor now forced the streamlining as we cannot accept the introduced problems, inconsistency in display, UX issues in navigation and keyboard accessibility as it voids nav patterns. This solution now implemented here seems to be the most widely accepted one, also used by Material, adobe and others and is now completely keyboard accessible in contrast to different solutions and follows the WCAG recommendations. Scan be fully accessed through keyboard and also shift + scroll wheel (native horizontal scrolling) is supported. The alternative option would be to only show a single dropdown with all options available, but a mix is a bad solution as it also mixed navigation pattern within a single list. As we would not allow the user to navigate within same list and will generate a context jump depending on the size. This is not good and should only be the last resort for special cases but not something simple as tabs we use really often. Also keeping the display as is now and not collapsing it can be an option here. But it then will still have the same problem at least on the display side as now, we have multiline hovering styles combined with elements sitting on something and others not. It will consume space depending on viewport size etc., as we know it. The important thing is that we have one behavior for tabs and not different ones. Personally, I think we need to reduce tabs and group them better so the problem that a user is actually running into the overflow should at some point only be a matter of the usage on a mobile device. Styleguide has only debugging records with really overloaded tabs. Maybe this is a good trigger to rethink the record here? I honestly do not know how to deal with Styleguide here. I personally always find it hard to find something in there, because it´s also not clear if it's a basic record or hidden in something else, usually i need to navigate just all of them.
  30. Garvin Hicking commented on patch set 12 03/07/26, 07:51

    Reply

    Thanks... thinking about it more, maybe this is an edge case and we don't have too many multiline tabs. I see this is difficult to solve. But I understand we need to streamline. Resolving this.
  31. Oli Bartsch commented on patch set 12 03/08/26, 00:18

    Reply

    Clicking on the end arrow does not scroll to the end. The last item is cut off then. Clicking on the arrow a second time leads to jumping because the arrow then disappears. Same happens when clicking on first or last item. When on last item and selecting items next to the start arrow, the last item is completely gone as scroll position is wrong. However, as already said in the previous comment, we decided to use a simple dropdown. No unreliable scrolling, no jumping arrows, no cut off items.
  32. Benjamin Kott uploaded patch set 13 V +1 03/09/26, 07:50

  33. core-ci voted on patch set 13 V -1 03/09/26, 08:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97588

  34. Benjamin Franzke uploaded patch set 14 V -1 03/09/26, 15:19

  35. core-ci voted on patch set 14 V -1 03/09/26, 15:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97607

  36. Benjamin Franzke uploaded patch set 15 V -1 03/09/26, 18:45

  37. Benjamin Franzke commented on patch set 15 03/09/26, 18:47

    Reply

    Fixed.
  38. core-ci voted on patch set 15 V +1 03/09/26, 18:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97616

  39. Oli Bartsch commented on patch set 15 03/10/26, 09:09

    Reply

    It's still not a dropdown, so I don't understand how this comment can be resolved.
  40. Benjamin Kott commented on patch set 15 CR -1 03/10/26, 17:03

    invalid migration of tabs used with ajax routes
  41. Benjamin Kott uploaded patch set 16 CR -1 V +1 03/10/26, 17:10

  42. core-ci voted on patch set 16 V +1 03/10/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97712

  43. Benjamin Franzke commented on patch set 16 03/10/26, 18:30

    Reply

    > There is a design, which as been discussed and approved by us. It clearly uses a dropdown. > It's still not a dropdown, so I don't understand how this comment can be resolved. There was no chance for us to approve anything, your context-panel was "Ready for review" for one hour. Please read our house rules before declaring that things have been discussed and/or approved: https://typo3.community/contribute/teams-committees/typo3-development/house-rules > A reasonable amount of time was given for peers to reviews (for any non-trivial change at least 24hs, for more significant changes 48hs, some exceptions happen during code sprints or coding nights of the TYPO3 Developer Days) I wanted to ignore that part because I consider your comment as trolling, but if you really want to be disproved on this argument as well: Aria `role=tablist` does not support the "more tabs" pattern currently. That means your previous implementation also violated accessibility requirements in this regard. (Next to introducing unreadable contrast in dark mode) See https://github.com/w3c/aria/issues/1199 Oli, stop trying to block us from cleaning up the mess you merged without letting anyone a chance for a proper review. This is harmful. Again, I ask you to think thoroughly about your actions and behavior.

    tab.ts:253

    We should not wrap HTML like this, this should be a webcomponent instead.

    tab.ts:357

    We need to wrap this in a component (see above) or at least allow dynamic activation, but a component is highly appreciated.

    tabs.ts:72

    It is easy for us to be non-breaking here, we should preserve this file/export since it was not marked internal.
  44. Benjamin Kott commented on patch set 16 03/10/26, 18:37

    tab.ts:253 Reply

    i am unsure about this, i have also thought about this, but it would require dealing with shadow-dom and slots, we also did the simple route on the dropdowns but i am open to this discussion. the goal was to keep it easy and understandable.

    tab.ts:357 Reply

    see above

    tabs.ts:72 Reply

    the export was a wrapper file; we can simply reexport the tabs here - not sure if its actually worth, its only the persistence for the tabs.
  1. Benjamin Franzke voted on patch set 16 CR -1 03/10/26, 20:07

  2. Oli Bartsch commented on patch set 16 03/10/26, 21:43

    Reply

    The design was discussed a long time before the patch, among others by the author of this patch. It uses a dropdown, no concerns have been raised. However, again, you convert a technical discussion into a personal attack by the language you chose to use. Calling my review comments "trolling", my work "a mess", telling me to "think thoroughly about my actions and behavior" and publicly accusing me of being harmful to the project. That is disrespectful, it is out of line, and it has no place in a professional community environment. Someone who speaks to their colleagues like this in public disqualifies themselves from any leadership role and I think the community will keep that in mind. This is a public forum and the community can read every word of this thread.
  3. Benjamin Kott commented on patch set 16 03/10/26, 21:53

    Reply

    @bo@cedev.de i may remind you that we did not discuss this to an extent, as we NEVER had this on the agenda to do because of timing issues. there was no agreement on the solution. The only agreement we had that we think the feature is useful and we want that feature. It was also stated that this will take a long time to implement as I listed the things we probably need to do to also make it look like that. Things i am now picking up and actively doing. It also included a lot more of requirements that are also ignored here.
  4. Helmut Hummel commented on patch set 16 03/11/26, 09:00

    Reply

    @benjamin.kott@outlook.com I think you are talking past one another because you are on a different level. You have technical concerns about some code being merged, while @bo@cedev.de addresses the way these concerns are raised by @ben@bnf.dev From my point of view there is zero justification for how Oli has been personally attacked in this thread.
  5. Benjamin Kott commented on patch set 16 03/11/26, 10:35

    Reply

    @typo3@helhum.io i just tried to clear up the misunderstanding that the current form was in any way approved or endorsed from my side as it was pointed out here not decided in the mentioned working group to do it that way. there was clearly no decision taken, just remarks that we need to check in advance and see how we can make it work. This was already explained also with possible solution in my comment in the question Garvin asked. > The design was discussed a long time before the patch, among others by the author of this patch. It uses a dropdown; no concerns have been raised.
  6. Oli Bartsch commented on patch set 16 03/11/26, 13:16

    Reply

    It really feels we are going in circles. On purpose, I wrote "discussed". I never said "approved." The dropdown was the only solution we talked about. What is introduced with this patch was never designed, nor discussed. I fully acknowledge the concerns regarding the "more tabs" pattern. This is something we should solve together, whether that ends up being a scrollable bar or something else entirely. That is all I am asking for: let's talk. > as we NEVER had this on the agenda Please remember the meeting we had, which actually included stakeholders, where the context panel was presented as one of three working packages for v14. Only the page wizard was defined to be sponsored and developed by the founded task force. I took ownership of one of the remaining topics at our own cost, to deliver additional value for v14.
  7. Benjamin Franzke commented on patch set 16 03/11/26, 13:24

    Reply

    > publicly accusing me of being harmful to the project I already expressed by excused personally in the core-merger slack channel and offered to have talk to get back together and I want to repeat it here again: I'm sorry for not talking to you personally before posting my critics in here. I'm sorry that this was perceived as an attack, while it was not my intention. I'm still offering to talk with you. I believe we both can manage this if we try to get over our disappointments.
  8. Benjamin Kott uploaded patch set 17 CR -1 V +1 03/17/26, 07:11

  9. Benjamin Kott commented on patch set 17 03/17/26, 07:15

    Reply

    i am resolving this part of the discussion here is based on personal feelings and has nothing impactful for a technical review.
  10. core-ci voted on patch set 17 V +1 03/17/26, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98072

  11. Benjamin Franzke uploaded patch set 18 V +1 03/17/26, 10:16

  12. Benjamin Franzke commented on patch set 18 03/17/26, 10:16

    tab.ts:253 Reply

    Done

    tab.ts:357 Reply

    Done

    tabs.ts:72 Reply

    Done
  13. core-ci voted on patch set 18 V +1 03/17/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98083

  14. Oli Bartsch commented on patch set 18 03/17/26, 11:06

    Hi, I cannot find any explanation for why tab overflow is now handled using scroll arrows. I also don’t see where this approach was discussed or agreed upon within the team. The only design reference I’m aware of uses a dropdown. Could you clarify where this change originates from, who decided on it, and on what basis? Additionally, while the updated visual appearance was initially intended to be tested within the context panel only, it is now being applied across the backend. In those areas, related components, such as the main form engine view, are not yet aligned. This results in two separate bodies with borders and spacing between them, making it unclear that they belong together. When was the decision made to introduce a new tabs component across the entire backend, and by whom? Are there plans to align the related parts accordingly?
  15. Benjamin Kott commented on patch set 18 03/17/26, 12:31

    Reply

    The reasoning behind the scroll-arrow approach for tab overflow was already explained in the earlier discussion on this patch. To summarize: the dropdown-based overflow pattern, while the only solution previously discussed, conflicts with the W3C ARIA Authoring Practices Guide. The role="tablist" specification does not define a "more tabs" dropdown pattern; introducing a dropdown control inside a tablist creates inconsistent keyboard interaction semantics and breaks the expected behavior for assistive technologies. Accessibility requirements take precedence over design preferences in TYPO3, which is why the scroll-based approach was chosen. Regarding the backend-wide visual rollout: visual changes in TYPO3 are always applied globally. A consistent UI across all views is a core principle and partial design states are not something we ship. The styling changes were introduced by #109130, and a consistent global rollout is the only alternative to reverting those styling changes entirely. Upcoming patches will ensure the remaining parts are visually aligned as well. On the concern about two separate bodies with borders and spacing: this is the same editing interface. #109130 introduced slight visual adjustments to it and the structural relationship between the components has not changed. Hope this clarifies the reasoning. Happy to discuss further if needed.
  16. Oli Bartsch commented on patch set 18 03/17/26, 15:49

    Reply

    TBH, with all the back and forth I forgot about these reasons. So thanks. I can follow the arguments, but I'm still missing where this direction was discussed or agreed upon. A patch of this scope replacing an existing implementation really should come with that context. In the description, the commit message, or a linked discussion. None of that is there. I might live with a global rollout but want to point out that I do not recall that this core principle has been defined by the core team. If I'm wrong, I genuinely appreciate a pointer to the relevant document. I think there's value in being able to try things out at a small, contained scope. Especially when the "experiment" is behind a feature toggle. We've tried POCs under those conditions before, and I don't think this case is fundamentally different.
  17. Benjamin Kott commented on patch set 18 03/17/26, 17:20

    Reply

    Regarding the documentation of the scroll-arrow decision: we acknowledge that we fall short on this in the commit message. The message covers the custom API, ARIA handling, keyboard navigation patterns, backward compatibility, legacy markup migration and tab persistence, and we kept it focused on those essentials. The reasoning behind the switch from dropdown to scroll arrows was not included, and that is a fair point. The accessibility reasoning was discussed in detail in the previous comments on this patch. On the global rollout principle: this may not be explicitly documented, but it is a well-established practice that every merger is aware of. We have been working for years to streamline and consolidate the TYPO3 backend and it is a continuous effort to keep things clean and consistent. Every change is a step in that direction and every exception creates technical and visual debt that someone has to resolve later. This is not a principle that needs to be revisited on each individual patch. To be transparent: the global rollout was the direct consequence of the decision to include styling changes in #109130 and the subsequent decision not to revert them. If we had wanted to avoid this situation, the styling changes should not have been part of the initial patch and should have been rolled out globally only once the full picture was ready. These are decisions that can absolutely be made, but they come with the responsibility to align all involved parties upfront, follow through immediately and take care of everything that comes with it, including the global rollout, the fixes that need to be addressed and the open issues identified along the way. That is exactly what is happening right now with this and the related patches. On the comparison to a POC behind a feature toggle: the context editing panel is a user setting, which is a fundamentally different concept. A feature toggle is disabled by default and serves as an explicit opt-in. Beyond that, the feature was never labeled or treated as experimental in any way — no indicator, no documentation, nothing suggested it was anything other than a permanent addition to the core. The experimental framing is understandable given the circumstances, but it does not reflect how the feature was introduced. Shipping a partial rollout of styling changes would result in two visually inconsistent states of the same interface reaching all users simultaneously, which is something we want to avoid. Upcoming patches will align the remaining parts visually.
  18. Benjamin Kott commented on patch set 18 03/17/26, 17:31

    Reply

    One more thing worth mentioning: the video recordings for the TYPO3 v14 LTS release are starting next week. Having an inconsistent backend UI at that point is not an option, which makes completing the global visual alignment not just the right thing to do but also time critical.
  19. Benjamin Kott uploaded patch set 19 CR +1 V +1 03/18/26, 07:54

  20. core-ci voted on patch set 19 V +1 03/18/26, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98141

  21. Benjamin Franzke voted on patch set 19 CR +1 V +1 03/18/26, 08:03

  22. Oli Bartsch commented on patch set 19 CR +1 V +1 03/18/26, 08:23

    Reply

    Acknowledged
  23. Benjamin Franzke voted on patch set 19 CR +2 V +2 03/18/26, 08:30

  24. Benjamin Franzke merged patch set 20 03/18/26, 08:31

  25. Benjamin Franzke commented on patch set 20 03/18/26, 08:39

    Reply

    thanks! 👍