Review main Merged

93098[BUGFIX] Remove badge-success style override in contextual record edit

Benjamin Kott CR +2 V +2 Easy +0 −8 updated 03/07/26, 03:07

Commit message

Badge classes like `badge-success` carry semantic intent and must
not be overridden with hardcoded color values. The removed styles
used fixed hex colors incompatible with light and dark color schemes.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 89

  1. Benjamin Kott uploaded patch set 1 03/06/26, 01:03

  2. core-ci voted on patch set 1 V +1 03/06/26, 01:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97451

  3. Georg Ringer voted on patch set 1 CR +1 V +1 03/06/26, 09:32

  4. Josua Vogel voted on patch set 1 CR +1 V +1 03/06/26, 09:43

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 03/06/26, 12:22

  6. Benjamin Kott merged patch set 2 03/06/26, 12:22

  7. Oli Bartsch commented on patch set 2 03/06/26, 16:19

    Overwriting badge-success directly wasn't ideal, agreed. But the color change is a design requirement. So what's the right way to handle this now?
  8. Benjamin Kott commented on patch set 2 03/07/26, 02:30

    Reply

    This has nothing to do with; it was not ideal. And we should stop putting nice words around this. It was plain wrong and should not have happened in the first place. We blocked such changes before for the same reasons. It also cannot simply be assigned to purple, because we only use purple in the fresh theme, and it would also need to have supported light dark. Also, there cannot be a simple design change to a stateful class. If we provide intend and status here in this case allowed (green) / disallowed (red) the color cannot be changed, simple as that just like that in a drive by and not only in one specific place and leave the normal display untouched. This is not how we work. This does not mean we cannot change something, but we are currently using "success" here that is defined as "Green". We have variants available also for "primary" that would also have adjusted to the other color schemes we provide. In its current forms Blue and Purple, but also every other color a user can define at some point. "IF" we now want to put less empathize on the "allow" version and decide to use primary for that and only highlight "disallow" as "danger/red", this is something we can do, but this is a redefinition of how we handle these lists. And this change will need to be executed everywhere.
  9. Benjamin Kott commented on patch set 2 03/07/26, 03:07

    Reply Unresolved

    See: 93115: [TASK] Use primary state for allowed file extension badges | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93115