Review main Merged

93100[TASK] Upgrade to CKEditor 5 v47.6

Benjamin Franzke CR +2 V +2 Nightmare +1943 −1901 updated 03/06/26, 10:54

Commit message

CKEditor 5 v47.6 [1] fixes a theoretical XSS issue [2] in the
General HTML Support (GHS) feature, which could be explouted
in case CSP is disabled (not allowed in our backend) and if
CKEditor configuration uses an insecure configuration
(allows inline JavaScript attributes like `onclick` [3]).

Used commands:

  cd Build
  npm --prefix overrides/ckeditor5 version 47.6.0
  npm install --save ./overrides/ckeditor5 $(
    grep @ckeditor/ package.json | \
    grep -v @ckeditor/ckeditor5-dev-utils | \
    grep -v @ckeditor/ckeditor5-inspector | \
    sed 's/^[^"]*"\([^"]*\)".*/\1@47.6.0/' \
  )
  npm run build

[1] https://github.com/ckeditor/ckeditor5/releases/tag/v47.6.0
[2] https://github.com/ckeditor/ckeditor5/security/advisories/GHSA-jrqm-vmqc-gm93
[3] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html#security

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 121

Show 101 more files

Review log 56

  1. Benjamin Franzke uploaded patch set 1 03/06/26, 09:48

  2. core-ci voted on patch set 1 V +1 03/06/26, 10:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97477

  3. Georg Ringer voted on patch set 1 CR +1 V +1 03/06/26, 10:24

  4. Oliver Hader voted on patch set 1 CR +1 V +1 03/06/26, 10:38

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/06/26, 10:50

  6. Benjamin Franzke merged patch set 2 03/06/26, 10:54