Review main Merged

93105[DOCS] Clarify addQueryString option in ext:form documentation

Josua Vogel CR +2 V +2 Easy +2 −2 updated 03/06/26, 13:28

Commit message

The `addQueryString` rendering option in ext:form was documented
with data type `bool`, which does not reflect the actual accepted
values since TYPO3 v12.

With the introduction of Feature #98488, `addQueryString` also
accepts the string value `'untrusted'` to include all current GET
query parameters in the form action URL. Setting `addQueryString`
to `true` only forwards parameters resolved by route enhancers,
which is a behavioral change from TYPO3 v11 where `true` forwarded
all GET parameters.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Josua Vogel uploaded patch set 1 03/06/26, 11:49

  2. core-ci voted on patch set 1 V +1 03/06/26, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97490

  3. Josua Vogel updated the commit message in patch set 2 V +1 03/06/26, 12:47

  4. Garvin Hicking voted on patch set 2 CR +1 V +1 03/06/26, 12:48

  5. Benni Mack voted on patch set 2 CR +1 V +1 03/06/26, 13:26

  6. core-ci voted on patch set 2 V +1 03/06/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97501

  7. Garvin Hicking voted on patch set 2 CR +2 V +2 03/06/26, 13:28

  8. Garvin Hicking merged patch set 3 03/06/26, 13:28