93114[TASK] Move record header rendering from FormEngine to controllers
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Georg Ringer +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Georg Ringer +1
Issues 2
Files 46
- Build/Sources/Sass/component/_recordidentity.scssnew+19 −0
- Build/Sources/Sass/typo3/_contextual_record_edit.scss+0 −6
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/Sass/_minimal.scss+1 −0
- Build/tests/playwright/e2e/layout/open-in-new-window-language-switching.spec.ts+1 −1
- Build/tests/playwright/e2e/media/file-meta-data.spec.ts+1 −1
- Build/tests/playwright/e2e/records/sys-note.spec.ts+2 −2
- Build/tests/playwright/e2e/recycler/recycler-module.spec.ts+3 −3
- Build/tests/playwright/e2e/redirects/qrcode-module.spec.ts+4 −4
- Build/tests/playwright/e2e/redirects/redirects-module.spec.ts+4 −4
- Build/tests/playwright/e2e/setup/setup-module.spec.ts+1 −1
- Build/tests/playwright/e2e/users/users-module.spec.ts+6 −6
- typo3/sysext/backend/Classes/Controller/ContextualRecordEditController.php+5 −13
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php8+104 −97
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php2+21 −9
- typo3/sysext/backend/Classes/Form/Container/FormWrapContainer.php2new+71 −0
- typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php3+7 −1
- typo3/sysext/backend/Classes/Form/NodeFactory.php+1 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_siteconfiguration.xlf+7 −1
- typo3/sysext/backend/Resources/Private/Templates/Form/FormWrapContainer.fluid.htmlnew+23 −0
Show 26 more files
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-109192-FormEngineOuterWrapContainer.rst3new+64 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf2+6 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicEmailCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputEvalCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputRangeCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputSimpleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputTextTableCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicNumberCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicPasswordCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsEmptyElementsCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsSelectMultipleSideBySideWithKeyboardCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FileCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlinePagesLocalizeResourceCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/LinkBrowserCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/NullPlaceholderCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/NewRecordTypeCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/SchedulerTaskWizardCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/SearchCest.php+1 −1
Review log 5887
Show 3862 earlier messages
-
Benjamin Kott uploaded patch set 1 03/07/26, 01:53
-
core-ci voted on patch set 1 V -1 03/07/26, 02:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97530
-
Benjamin Kott uploaded patch set 2
V -103/09/26, 15:37 -
Benjamin Kott updated the commit message in patch set 3 03/09/26, 15:43
-
core-ci voted on patch set 2 V -1 03/09/26, 15:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97608
-
Benjamin Kott uploaded patch set 4 03/09/26, 16:15
-
core-ci voted on patch set 3 V -1 03/09/26, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97609
-
core-ci voted on patch set 4 V -1 03/09/26, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97611
-
Oli Bartsch commented on patch set 4 03/09/26, 17:19
-
Benjamin Kott uploaded patch set 5
V -103/09/26, 17:32 -
Benjamin Kott commented on patch set 5 03/09/26, 17:51
OuterWrapContainer.php:23Replyi am not sure what's the best solution here i pinged @lolli@schwarzbu.ch on this change. the patch now delivers the results intended also with the changed and adjusted titles and shortcut names - we now need to find a way make it work. -
Benjamin Kott uploaded patch set 6 03/09/26, 18:01
-
core-ci voted on patch set 5 V -1 03/09/26, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97614
-
core-ci voted on patch set 6 V -1 03/09/26, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97615
-
Benjamin Kott uploaded patch set 7
V -103/09/26, 21:10 -
core-ci voted on patch set 7 V -1 03/09/26, 21:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97620
-
Benjamin Kott uploaded patch set 8
V -103/09/26, 21:59 -
Benjamin Kott uploaded patch set 9 03/09/26, 22:02
-
core-ci voted on patch set 8 V -1 03/09/26, 22:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97621
-
core-ci voted on patch set 9 V -1 03/09/26, 22:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97622
-
Benjamin Kott uploaded patch set 10
V -103/09/26, 23:02 -
Benjamin Kott uploaded patch set 11 03/09/26, 23:35
-
core-ci voted on patch set 10 V -1 03/09/26, 23:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97623
-
Benjamin Kott uploaded patch set 12 03/09/26, 23:40
-
core-ci voted on patch set 11 V -1 03/09/26, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97624
-
core-ci voted on patch set 12 V -1 03/10/26, 00:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97625
-
Benjamin Kott uploaded patch set 13
V -103/10/26, 01:20 -
core-ci voted on patch set 13 V -1 03/10/26, 01:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97628
-
Benjamin Kott uploaded patch set 14
V -103/10/26, 10:34 -
core-ci voted on patch set 14 V -1 03/10/26, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97674
-
Benjamin Kott uploaded patch set 15
V -103/10/26, 11:26 -
core-ci voted on patch set 15 V -1 03/10/26, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97681
-
Benjamin Kott uploaded patch set 16
V -103/10/26, 11:50 -
Benjamin Kott commented on patch set 16 03/10/26, 11:51
OuterWrapContainer.php:23ReplyDone, restored the container and added a deprecation. -
Benjamin Kott uploaded patch set 17 03/10/26, 11:54
-
Benjamin Kott uploaded patch set 18 03/10/26, 12:03
-
core-ci voted on patch set 17 V -1 03/10/26, 12:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97685
-
core-ci voted on patch set 18 V -1 03/10/26, 12:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97690
-
Benjamin Kott uploaded patch set 19
V -103/10/26, 12:30 -
core-ci voted on patch set 17 V -1 03/10/26, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97685
-
core-ci voted on patch set 19 V -1 03/10/26, 12:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97693
-
Benjamin Kott uploaded patch set 20
V -103/10/26, 13:11 -
Benjamin Kott uploaded patch set 21 03/10/26, 13:15
-
core-ci voted on patch set 21 V +1 03/10/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97697
-
Benjamin Franzke commented on patch set 21 03/10/26, 19:59
EditDocumentController.php:2044I think the label "Unique ID" is to verbose in this view. I'd prefer `[23233]` with title `Unique ID: 23233`. -
Christian Kuhn commented on patch set 21 03/10/26, 20:27
i understand formEngine could have a different entry container so controllers have better 'surrounding' capabilities. i'll try to understand details of this approach within this week and will try to report. -
Benjamin Franzke uploaded patch set 22
V +103/10/26, 20:33 -
Benjamin Franzke commented on patch set 22 03/10/26, 20:33
EditDocumentController.php:2044ReplyDone -
Benjamin Franzke commented on patch set 22 03/10/26, 20:46
Reply
FYI: my vote and your comment overlapped – I did not intent to "ignore" this. For me the actual idea was easy to follow in patchset 15, before Benji added a new container, where he only stripped down the old one: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93114/15/typo3/sysext/backend/Classes/Form/Container/OuterWrapContainer.php (alternatively also helpful: `diff typo3/sysext/backend/Classes/Form/Container/{OuterWrapContainer,FormWrapContainer}.php`) …and I think it makes sense to decouple all kinds of surroundings like: * record document `<title>` * record header (previously in OuterWrapContainer) * record breadcrumb and record breadcrumb to the controller To have a single point where surroundings for the respective context are managed. -
core-ci voted on patch set 22 V +1 03/10/26, 21:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97718
-
Christian Kuhn commented on patch set 22 CR -1 03/13/26, 08:24
i mainly looked at the formEngine/controllor side and think this part of the change is reasonable. it's fine with me when the nits are done.it would be good to rephrase here since latest patch set deprecates OuterWrapContainer and introduces a new one.EditDocumentController.php:360could we inline $documentTitle instead and hand it around if needed instead of creating even more class state?SiteConfigurationController.php:846no named arguments for casual methods.FormWrapContainer.php:25empty __construct() can be removed. -
Benjamin Kott uploaded patch set 23
CR +1V +103/13/26, 13:15 -
Benjamin Kott commented on patch set 23 03/13/26, 13:16
Reply
please resolve this when you are done checking the requested changesReply
DoneEditDocumentController.php:360ReplyDoneSiteConfigurationController.php:846ReplyDoneFormWrapContainer.php:25ReplyDone -
core-ci voted on patch set 23 V -1 03/13/26, 13:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97898
-
Benjamin Kott uploaded patch set 24
V -103/13/26, 14:02 -
core-ci voted on patch set 24 V +1 03/13/26, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97904
-
Benjamin Kott commented on patch set 24 03/16/26, 07:22
Reply
Done -
Garvin Hicking commented on patch set 24 03/16/26, 08:01
Deprecation-109192-FormEngineOuterWrapContainer.rst:62Could we have convenience API methods that would do this? formWrapContainer->renderRecordHeading() formWrapContainer->renderRecordFooting() Then maybe we could even think about keeping "outerWrapContainer" and just parametrize it, and set "showHeader/showFooter" to true for now, but "false" for the future. This could then allow extensions to more seamlessly upgrade and not break, if they don't care about that extra info...?locallang_core.xlf:384We could utilize ICU plural form syntax here? -
Benjamin Kott uploaded patch set 25
V +103/16/26, 09:38 -
Benjamin Kott commented on patch set 24 03/16/26, 09:41
Deprecation-109192-FormEngineOuterWrapContainer.rst:62Replyi think the form-engine should not care about, this is what the patch actually does. there is no benefit in having these generic titles for the forms. i agree that generating the titles is not straight forwards but this is something to resolve somewhere else. you will only run into this if you have modules that manually generate form engine editing views that do not use the edit document controller.locallang_core.xlf:384ReplyDone -
core-ci voted on patch set 25 V -1 03/16/26, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98000
-
Benjamin Kott uploaded patch set 26
V -103/16/26, 10:42
-
core-ci voted on patch set 26 V +1 03/16/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98007
-
Garvin Hicking commented on patch set 26 03/17/26, 07:46
Deprecation-109192-FormEngineOuterWrapContainer.rst:62ReplySorry I forgot to reply here. I'm not deep enough into the specifics here and trust your process, so am resolving this. -
Benjamin Franzke commented on patch set 26 CR -1 03/17/26, 11:30
EditDocumentController.php:354There is an empty `<h1></h1>` when opening an extbase plugin like `blog_posts`. Let's add `[No title]`. -
Benjamin Kott uploaded patch set 27
CR -1V +103/17/26, 14:57 -
Benjamin Kott commented on patch set 27 03/17/26, 14:57
EditDocumentController.php:354ReplyDone -
core-ci voted on patch set 27 V +1 03/17/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98096
-
Benjamin Franzke commented on patch set 27 CR +1 V +1 03/18/26, 04:13
EditDocumentController.php:897In resolveDocumentTitle we use `core.core:labels.no_title` directly. I do not understand why we use `BackendUtility::getNoRecordTitle()` instead. From a security perspective that is less ideal, since we "need" to rely on `BackendUtility::getNoRecordTitle` applying `hsc`. Anyway, this is not wrong, but just opinion, so I'm fine with this. -
Benjamin Franzke rebased onto patch set 28
CR +1V +103/18/26, 04:39 -
core-ci voted on patch set 28 V +1 03/18/26, 04:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98125
-
Benjamin Franzke voted on patch set 28 CR +1 V +1 03/18/26, 05:03
-
Benjamin Franzke uploaded patch set 29
CR +1V +103/18/26, 08:10 -
Benjamin Franzke commented on patch set 29 03/18/26, 08:10
EditDocumentController.php:897ReplyAdapted. -
Benjamin Franzke voted on patch set 29 CR +1 V +1 03/18/26, 08:10
-
core-ci voted on patch set 29 V -1 03/18/26, 08:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98143
-
Benjamin Franzke uploaded patch set 30
CR +1V +103/18/26, 08:27 -
Benjamin Franzke voted on patch set 30 CR +1 V +1 03/18/26, 08:27
-
Georg Ringer voted on patch set 30 CR +1 V +1 03/18/26, 08:31
-
Benjamin Franzke uploaded patch set 31
CR +1V +103/18/26, 08:32Resolve Merge-Conflict -
Benjamin Franzke voted on patch set 31 CR +1 V +1 03/18/26, 08:32
-
core-ci voted on patch set 30 V +1 03/18/26, 08:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98144
-
Georg Ringer voted on patch set 31 CR +1 V +1 03/18/26, 08:42
-
Benjamin Kott voted on patch set 31 CR +2 V +2 03/18/26, 08:43
-
Benjamin Kott merged patch set 32 03/18/26, 08:43
-
Oli Bartsch commented on patch set 32 03/18/26, 16:42
Unresolved
There is no reason given why the information on which page the current record (type) is edited is no longer relevant. Additionally, this now leads to displaying "undefined" when editing frontend users, see screenshot in #109289. -
Lina Wolf commented on patch set 32 05/25/26, 06:28
Unresolved
Is usage in TCA like in the ctrl container section affected as well? [container](https://docs.typo3.org/permalink/t3tca:confval-ctrl-container)? What about this example: [Add your own wizard](https://docs.typo3.org/permalink/t3tca:tca-example-ctrl-container-cusotm)
OuterWrapContainer.php:23