93115[TASK] Use secondary state for allowed file extension badges
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Franzke +1
- Riccardo De Contardi +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/backend/form-engine/element/online-media-form-element.ts+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/backend/Classes/View/ResourceUtilityRenderer.php+4 −4
- typo3/sysext/backend/Resources/Private/Templates/Form/FilesControlContainer.fluid.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/online-media-form-element.js+1 −1
Review log 1315
-
Benjamin Kott uploaded patch set 1 03/07/26, 03:04
-
Benjamin Kott commented on patch set 1 CR -2 03/07/26, 03:04
please discuss if we want this change -
core-ci voted on patch set 1 V +1 03/07/26, 03:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97533
-
Georg Ringer commented on patch set 1 03/07/26, 06:30
I am really not into information design but why not using -info? -
Riccardo De Contardi commented on patch set 1 03/07/26, 07:31
there has been a discussion on Slack https://typo3.slack.com/archives/C027S88NY/p1766244782699889 I would tone the list down as shown on my screenshots -
Benjamin Franzke commented on patch set 1 03/09/26, 08:39
I like "primary" over "success", but since these states do not represent actions, their appearance now takes too much attention. Some shading would be desirable. -
Oli Bartsch commented on patch set 1 03/09/26, 09:51
I do not understand why we spend time creating mockups and designs if we ultimately do not follow them, but instead introduce new ideas that are then discussed further based on personal preferences. This seems like a significant waste of time and money. Aside from that, it also comes across as not very respectful toward the people who invested time in creating those designs. -
Benjamin Franzke uploaded patch set 2
V +103/09/26, 14:34Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke commented on patch set 2 03/09/26, 14:34
Reply
I think secondary is actually the right choice here. I adapted the patch accordingly. -
Benjamin Franzke voted on patch set 2 CR +1 V +1 03/09/26, 14:34
-
Riccardo De Contardi voted on patch set 2 V +1 03/09/26, 14:42
-
core-ci voted on patch set 2 V +1 03/09/26, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97605
-
Benjamin Kott commented on patch set 2 CR 0 03/09/26, 16:17
vote and resolve if you agree here, will not merge the patch as it was only to showcase the correct place for the adjustments. -
Oli Bartsch commented on patch set 2 CR +2 V +2 03/09/26, 18:32
Reply
Done -
Oli Bartsch merged patch set 3 03/09/26, 18:32