93116[DOCS] Clarify the correct migration of TSFE->config['config']
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Christian Kuhn +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Simon Schaufelberger uploaded patch set 1 03/07/26, 21:40
-
core-ci voted on patch set 1 V +1 03/07/26, 21:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97551
-
Garvin Hicking commented on patch set 1 03/08/26, 08:58
-
Simon Schaufelberger commented on patch set 1 03/08/26, 09:59
Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18ReplyWhen using backticks, the Text is rendered as code. When it has the php Tag, it will render a stupid modal window which is very annoying and in this case, it's not even real php code but only a class name which is actually just a string. -
Simon Schaufelberger commented on patch set 1 03/08/26, 10:01
Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18ReplyLina is also not a big fan of the overuse of this Tag when you ask her. -
Garvin Hicking commented on patch set 1 CR -1 03/08/26, 10:31
Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18ReplyI think it's an important semantic. We should provide that. Then we can always replace a "stupid modal". We know nothing about a snippet if these semantics are missing. -
Simon Schaufelberger uploaded patch set 2
CR -1V +103/08/26, 19:20 -
Simon Schaufelberger commented on patch set 2 03/08/26, 19:21
Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18ReplyI would really appreciate any documentation where the correct usage of the tags are written down. -
core-ci voted on patch set 2 V +1 03/08/26, 19:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97573
-
Garvin Hicking commented on patch set 2 03/08/26, 19:39
Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18ReplyThanks. I'll try to find time to search for it, but I think our "how to document" guide has all language semantic annotations somewhere. (As for this patch I'd have to check the config['config'] use so I can't vote for it atm, but if anyone knows for sure please vote) -
Christian Kuhn voted on patch set 2 CR +1 V +1 03/09/26, 11:52
-
Josua Vogel voted on patch set 2 CR +1 V +1 03/09/26, 11:57
-
Garvin Hicking voted on patch set 2 CR +2 V +2 03/09/26, 12:22
-
Garvin Hicking merged patch set 3 03/09/26, 12:22
Breaking-102621-MostTSFEMembersMarkedInternalOrRead-only.rst:18