Review main Merged

93117[TASK] Prevent redundant hmac calculation in EXT:felogin password reset

Simon Schaufelberger CR +2 V +2 Easy +4 −2 updated 03/10/26, 13:29

Commit message

When resetting the password in felogin, it is not necessary to create
the hmac twice. The computation can be performed once to save
resources.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
    • Sebastian Iffland +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Torben Hansen +1
    • Sebastian Iffland +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Simon Schaufelberger uploaded patch set 1 03/08/26, 01:12

  2. Simon Schaufelberger uploaded patch set 2 03/08/26, 01:17

  3. core-ci voted on patch set 2 V +1 03/08/26, 01:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97555

  4. Garvin Hicking updated the commit message in patch set 3 V +1 03/08/26, 09:00

  5. Garvin Hicking voted on patch set 3 CR +1 V +1 03/08/26, 09:00

  6. core-ci voted on patch set 3 V +1 03/08/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97570

  7. Oliver Klee voted on patch set 3 CR +1 V +1 03/08/26, 18:03

  8. Georg Ringer voted on patch set 3 CR +1 V +1 03/10/26, 04:36

  9. Torben Hansen voted on patch set 3 CR +1 V +1 03/10/26, 06:46

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 03/10/26, 08:58

  11. Sebastian Iffland voted on patch set 3 CR +1 V +1 03/10/26, 09:05

  12. Garvin Hicking merged patch set 4 03/10/26, 13:29