Review 12.4 Merged

93120[TASK] Fix known vulnerabilities in CKEditor

Benjamin Franzke CR +2 V +2 Hard +582 −221 updated 03/10/26, 05:26

Commit message

Backport fixes from CKEditor 5 v47.6 [1] that address a theoretical XSS
issue [2] in the General HTML Support (GHS) feature, which could be
exploited in case CSP is now enabled and if CKEditor configuration uses
an insecure configuration [3].

Commands executed:
  npm install --save-dev patch-package
  npm pkg set scripts.postinstall=patch-package
  npx patch-package @ckeditor/ckeditor5-engine
  npx patch-package @ckeditor/ckeditor5-html-support
  npm install
  npm run build

[1] https://github.com/ckeditor/ckeditor5/releases/tag/v47.6.0
[2] https://github.com/ckeditor/ckeditor5/security/advisories/GHSA-jrqm-vmqc-gm93
[3] https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html#security

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 56

  1. Benjamin Franzke uploaded patch set 1 03/09/26, 11:09

  2. core-ci voted on patch set 1 V +1 03/09/26, 11:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97602

  3. Oliver Hader voted on patch set 1 CR +1 V +1 03/09/26, 16:48

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 03/09/26, 20:57

    works on my machine
  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/10/26, 05:25

  6. Benjamin Franzke merged patch set 2 03/10/26, 05:26