Review main Merged

93123[DOCS] Add Important.rst for issue #109176

Benjamin Franzke CR +2 V +2 Easy +44 −0 updated 03/10/26, 05:38

Commit message

During the v12 backport of #109176 we noticed
that our users might be impacted by the
iframe sandbox that CKEditor v47.6 enables
by default, which an Important.rst is added.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Oliver Hader +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1315

  1. Benjamin Franzke uploaded patch set 1 03/09/26, 17:27

  2. core-ci voted on patch set 1 V +1 03/09/26, 18:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97613

  3. Garvin Hicking commented on patch set 1 03/09/26, 18:32

    Can we use the `[DOCS]` prefix for this please?

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:14

    In v12, I thought https://review.typo3.org/c/Packages/TYPO3.CMS/+/93120 would only patch installs, but not upgrade to the "whole" 47.6.0 release? In that case this Changelog would need to be more specific, like "updated to 47.6.0 in TYPO3 v13+ (and a patched baseline version 44.1.0 for TYPO3 v12)" ?

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:33

    Hm this sentence reads odd, what is the double negation try to say? I think the second "not" should be removed?
  4. Garvin Hicking commented on patch set 1 03/09/26, 18:32

    Reply

    (maybe also `[DOCS] Add Important.rst for #109176 CKEditor iframe update` ?)
  5. Benjamin Franzke commented on patch set 1 03/09/26, 18:44

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:14 Reply

    yes, I wanted to rephrase that in the v12 backport. Ideally I'd like to ship a different .rst for v12 and >=v13 (we can use a different issue number if that's an issue otherwise).

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:33 Reply

    yes, second "not" is a left over.
  6. Garvin Hicking commented on patch set 1 03/09/26, 18:58

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:14 Reply

    That won't work though - the change log rendering only uses "main". We have no version specific changelog on docs.typo3.org.
  7. Garvin Hicking commented on patch set 1 03/09/26, 19:00

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:14 Reply

    My suggestion would be: Create a 12.4.x changelog, only describing what happens for v12. Then additionally have a 13.4.x changelog, describing it for v13+main. Both files could proably use this same patch and issue number, but a different timestamp.
  8. Oliver Hader uploaded patch set 2 V +1 03/09/26, 19:50

  9. Oliver Hader commented on patch set 1 03/09/26, 19:51

    Reply

    Done

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:14 Reply

    I've adjusted the document to focus more on TYPO3 v12.4.x.

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:33 Reply

    Done
  10. Oliver Hader voted on patch set 2 CR +1 V +1 03/09/26, 19:51

  11. core-ci voted on patch set 2 V +1 03/09/26, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97619

  12. Garvin Hicking commented on patch set 2 CR +1 V +1 03/09/26, 20:45

    fine by my thx!
  13. Simon Schaufelberger voted on patch set 2 CR +1 V +1 03/09/26, 22:26

  14. Benjamin Franzke commented on patch set 2 CR +2 V +2 03/10/26, 05:24

    Important-109176-CKEditorHardenedIframesByEnforcingSandboxBehavior.rst:14 Reply

    Thanks. I agree since its actually just that one sentence which needs differentiation.
  15. Benjamin Franzke merged patch set 3 03/10/26, 05:38