Review 13.4 Merged

93124[BUGFIX] Ensure core icons do not get stale due to browser caches

Benjamin Franzke CR +2 V +2 Easy +1 −0 updated 03/10/26, 08:34

Commit message

Since #108690 SVG sprites can be used for inline SVG
rendering by using `<use>` references.
It v13 this lead to issues that links to SVG sprites are – in contrast
to v14 – rendered without a cachebusting hash in their URL.

Therefore we re-apply the previous behavior, that all icons
shipped via @typo3/icons use the respective inline variants.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Eric Harrer +1
    • Garvin Hicking +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Eric Harrer +1
    • Garvin Hicking +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Benjamin Franzke uploaded patch set 1 03/09/26, 19:10

  2. core-ci voted on patch set 1 V +1 03/09/26, 19:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97618

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 03/09/26, 20:48

  4. Benjamin Kott voted on patch set 1 CR +1 V +1 03/10/26, 07:11

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 03/10/26, 07:11

  6. Benjamin Franzke merged patch set 2 03/10/26, 07:11

  7. Eric Harrer commented on patch set 2 CR +1 V +1 03/10/26, 08:34

    Although my review comes too late, here is my retrospective review: I can confirm that the 13.4 backport in https://review.typo3.org/c/Packages/TYPO3.CMS/+/92443 of my patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/92387 caused the regression. https://review.typo3.org/c/Packages/TYPO3.CMS/+/91445 subsequently made the problem visible by changing usages such as the page tree toggle to `actions-chevron-end`. v14 is not affected by this due to the new cache-busting hash. From my point of view, the merged fix addresses this in the best possible way for 13.4, since it restores the previous behavior with minimal scope. Thank you for the quick solution!