93134[BUGFIX] Fix form editor crash when editing forms in multiple browser tabs
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/form/Classes/Controller/FormEditorController.php+4 −4
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+32 −6
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+7 −9
- typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+3 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+2 −1
Review log 813
-
Garvin Hicking commented on patch set 1 03/10/26, 05:53
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Controller/FormEditorController.php * typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php * typo3/sysext/form/Tests/Functional/Controller/FormEditorControllerTest.php * typo3/sysext/form/Tests/Functional/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php -
core-ci voted on patch set 1 V -1 03/10/26, 05:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97643
-
Josua Vogel uploaded patch set 2
V -103/10/26, 06:49 -
Josua Vogel uploaded patch set 3 03/10/26, 06:55
-
core-ci voted on patch set 2 V -1 03/10/26, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97644
-
core-ci voted on patch set 3 V -1 03/10/26, 07:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97645
-
Josua Vogel uploaded patch set 4
V -103/10/26, 07:05 -
Josua Vogel uploaded patch set 5 03/10/26, 07:07
-
core-ci voted on patch set 4 V -1 03/10/26, 07:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97647
-
core-ci voted on patch set 5 V +1 03/10/26, 07:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97648
-
Garvin Hicking marked it ready for review 03/10/26, 08:41
-
Garvin Hicking voted on patch set 5 CR +2 V +2 03/10/26, 08:52
-
Garvin Hicking merged patch set 6 03/10/26, 08:52