Review main Merged

93139[TASK] Use FormDataCompiler in NewMultiplePagesController

Tobias Wojtylak CR +2 V +2 Normal +42 −43 updated 03/13/26, 12:48

Commit message

The patch exemplifies it can be quite straight forward to
calculate valid select field item lists of TCA fields using
FormEngine data processing scaffolding.

The target in this case is NewMultiplePagesController which
comes with custom drop-downs to select the page types to
be used for the new pages: By chaining the necessary
FormEngine data processors, the low level custom code can
be skipped.

The only headache was to create the needed list of data
processors, due to their implicit dependencies. It might
be a good idea to think about making these explicit within
the data processor classes to simplify.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1322

  1. Tobias Wojtylak uploaded patch set 1 03/10/26, 11:34

  2. core-ci voted on patch set 1 V -1 03/10/26, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97682

  3. Tobias Wojtylak uploaded patch set 2 V -1 03/10/26, 12:12

  4. core-ci voted on patch set 2 V -1 03/10/26, 12:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97691

  5. Tobias Wojtylak uploaded patch set 3 V -1 03/10/26, 13:38

  6. Tobias Wojtylak uploaded patch set 4 03/10/26, 13:41

  7. core-ci voted on patch set 4 V +1 03/10/26, 13:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97701

  8. core-ci voted on patch set 3 V -1 03/10/26, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97700

  9. Tobias Wojtylak uploaded patch set 5 V +1 03/10/26, 14:36

  10. core-ci voted on patch set 5 V +1 03/10/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97705

  11. Tobias Wojtylak marked it ready for review 03/11/26, 07:27

  12. Tobias Wojtylak uploaded patch set 6 V +1 03/11/26, 16:49

  13. core-ci voted on patch set 6 V +1 03/11/26, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97769

  14. Tobias Wojtylak uploaded patch set 7 V +1 03/12/26, 08:58

  15. core-ci voted on patch set 7 V -1 03/12/26, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97804

  16. Christian Kuhn uploaded patch set 8 V -1 03/13/26, 08:59

  17. Christian Kuhn commented on patch set 8 03/13/26, 09:00

    This change is ready for review.
  18. core-ci voted on patch set 8 V -1 03/13/26, 09:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97874

  19. core-ci voted on patch set 8 V +1 03/13/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97874

  20. Christian Kuhn voted on patch set 8 CR +1 V +1 03/13/26, 09:34

  21. Stefan Bürk voted on patch set 8 CR +2 V +2 03/13/26, 12:48

  22. Stefan Bürk merged patch set 9 03/13/26, 12:48