93145[TASK] Add TCA and schema as state to FormEngine $result
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 64
- typo3/sysext/backend/Classes/Controller/FormFilesAjaxController.php+6 −4
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+6 −4
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php+15 −16
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+20 −10
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+8 −6
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+7 −5
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+8 −6
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+8 −8
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+3 −2
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/UserSysFileStorageIsPublicElement.php+1 −3
- typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php+2 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php+2 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php2+7 −14
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseDefaultLanguagePageRow.php2+6 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseEditRow.php+2 −7
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php+4 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseUserPermissionCheck.php+1 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/InitializeProcessedTca.php+44 −9
Show 44 more files
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+11 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFiles.php+24 −16
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexPrepare.php+2 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexProcess.php+12 −0
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+28 −11
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineConfiguration.php+7 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+14 −9
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php+21 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTablePermission.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataCompiler.php+5 −0
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+11 −5
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Functional/Form/Container/FilesControlContainerTest.php+2 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCategoryTest.php+23 −4
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexPrepareTest.php+32 −31
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexProcessTest.php+31 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaInputPlaceholdersTest.php+160 −82
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+209 −148
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectTreeItemsTest.php+20 −8
- typo3/sysext/backend/Tests/Functional/Form/InlineStackProcessorTest.php+4 −3
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+6 −4
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+29 −9
- typo3/sysext/backend/Tests/Unit/Form/FieldWizard/TableListTest.php+2 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+22 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+10 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php+10 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+37 −70
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php+25 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+58 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineTest.php+3 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTablePermissionTest.php+18 −1
- typo3/sysext/core/Classes/Schema/SchemaCollection.php+37 −0
- typo3/sysext/core/Classes/Schema/TcaSchemaBuilder.phpnew+205 −0
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php3+13 −191
- typo3/sysext/core/Configuration/DefaultConfiguration.php+7 −7
- typo3/sysext/core/Tests/Functional/Database/Schema/AbstractSchemaBasedTestCase.php+2 −4
- typo3/sysext/core/Tests/Functional/Schema/TcaSchemaBuilderTest.phpnew+170 −0
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php+5 −2
- typo3/sysext/core/Tests/Unit/DataHandling/Localization/StateTest.php+5 −2
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+5 −2
- typo3/sysext/core/Tests/Unit/Domain/RecordFactoryTest.php+17 −8
- typo3/sysext/core/Tests/Unit/Schema/TcaSchemaFactoryTest.php+37 −171
- typo3/sysext/workspaces/Tests/Unit/EventListener/WorkspaceDependencyReferenceListenerTest.php+5 −2
Review log 3453
Show 1728 earlier messages
-
Bastien Lutz uploaded patch set 1 03/10/26, 14:22
-
Bastien Lutz marked it work in progress 03/10/26, 14:22
-
Bastien Lutz rebased onto patch set 2 03/10/26, 14:22
The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php * typo3/sysext/backend/Classes/Form/FormDataProvider/SiteDatabaseEditRow.php * typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php -
core-ci voted on patch set 1 V -1 03/10/26, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97703
-
core-ci voted on patch set 2 V -1 03/10/26, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97704
-
Bastien Lutz uploaded patch set 3
V -103/11/26, 09:06 -
core-ci voted on patch set 3 V -1 03/11/26, 09:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97742
-
Bastien Lutz uploaded patch set 4
V -103/11/26, 10:38 -
core-ci voted on patch set 4 V -1 03/11/26, 10:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97746
-
Bastien Lutz uploaded patch set 5
V -103/11/26, 13:36 -
core-ci voted on patch set 5 V -1 03/11/26, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97761
-
Bastien Lutz uploaded patch set 6
V -103/11/26, 15:59 -
core-ci voted on patch set 6 V -1 03/11/26, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97767
-
Bastien Lutz uploaded patch set 7
V -103/12/26, 17:14 -
core-ci voted on patch set 7 V -1 03/12/26, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97842
-
Bastien Lutz uploaded patch set 8
V -103/13/26, 12:12 -
core-ci voted on patch set 8 V +1 03/13/26, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97887
-
Bastien Lutz marked it ready for review 03/13/26, 12:40
-
Christian Kuhn uploaded patch set 9
V +103/17/26, 09:37 -
core-ci voted on patch set 9 V +1 03/17/26, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98081
-
Benni Mack commented on patch set 9 03/17/26, 13:13
TcaSchemaFactory.php:144please mark this method internal -
Christian Kuhn commented on patch set 9 03/17/26, 14:20
TcaSchemaFactory.php:144Replywe'll change this slightly: TcaSchemaFactory does 3 things currently: * it's goal is to be a statefull, injectable object representation of TCA, built during bootstrap. * it provides get() and has() for single schema * it contains the building to make this re-usable with 'fake tca' (like site settings), we'll do: * this->schemata in TcaSchemaFactory will be turned into an instance of SchemaCollection directly, not the array anymore. * move the worker code of get() and has() into SchemaCollection, both within TcaSchemaFactory will then just call $this->schemata->get()/has(). This gives us a short-hand within SchemaCollection, making it better usable * move build() out of TcaSchemaFactory into a new stateless TcaSchemaBuilder that receives 'the tca array' and returns SchemaCollection. * keep the cache stuff within TcaSchemaFactory this gives us: * TcaSchemaFactory is then clearly only an injectable object represention of globals-tca. no more, no less. * A seperate builder class that builds a collection from anything that 'looks like' TCA * A SchemaCollection that is quite easy to use. * A clear separation of concerns. it allows us to: * build tca schema easily from anything that 'looks like tca' and has no direct dependency to globals-tca. this state can then be hand around (for instance in formEngine). We then don't need buildWithoutCache(). -
Bastien Lutz uploaded patch set 10
V +103/17/26, 15:44 -
core-ci voted on patch set 10 V -1 03/17/26, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98101
-
Bastien Lutz uploaded patch set 11
V -103/18/26, 09:23 -
core-ci voted on patch set 11 V -1 03/18/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98154
-
Nikita Hovratov commented on patch set 11 03/18/26, 09:53
TcaSchemaFactory.php:144ReplyI like this, it would also solve an issue in Content Blocks, where I had to create a "simple" TcaSchema, to only create a Schema out of base TCA, without overrides. With that I could drop a lot of code. -
Bastien Lutz uploaded patch set 12
V -103/18/26, 11:06
-
Bastien Lutz uploaded patch set 13 03/18/26, 11:06
-
core-ci voted on patch set 12 V -1 03/18/26, 11:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98164
-
core-ci voted on patch set 13 V -1 03/18/26, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98165
-
Bastien Lutz uploaded patch set 14
V -103/18/26, 11:59 -
core-ci voted on patch set 14 V +1 03/18/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98171
-
Christian Kuhn uploaded patch set 15
V +103/18/26, 16:44 -
core-ci voted on patch set 15 V -1 03/18/26, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98209
-
Benni Mack commented on patch set 15 03/18/26, 16:57
AbstractItemProvider.php:1272the fields are now not prepended with "table.uid". That might become a problem.DatabaseDefaultLanguagePageRow.php:44let's please use the LanguageCapability -
Christian Kuhn uploaded patch set 16
V -103/18/26, 16:59 -
core-ci voted on patch set 16 V -1 03/18/26, 17:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98210
-
core-ci voted on patch set 16 V +1 03/18/26, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98210
-
Bastien Lutz uploaded patch set 17
V +103/19/26, 07:54 -
Bastien Lutz commented on patch set 16 03/19/26, 07:54
AbstractItemProvider.php:1272Replyalready resolved, as schema is not nullable anymore.DatabaseDefaultLanguagePageRow.php:44ReplyDone -
core-ci voted on patch set 17 V +1 03/19/26, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98225
-
Christian Kuhn voted on patch set 17 CR +1 V +1 03/21/26, 12:30
-
Oliver Klee voted on patch set 17 V +1 03/21/26, 12:32
-
Christian Kuhn uploaded patch set 18
CR +1V +103/21/26, 13:26 -
Christian Kuhn voted on patch set 18 CR +1 V +1 03/21/26, 13:26
-
core-ci voted on patch set 18 V +1 03/21/26, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98347
-
Oliver Klee voted on patch set 18 V +1 03/21/26, 15:44
-
Georg Ringer voted on patch set 18 CR +2 V +2 03/21/26, 22:24
-
Georg Ringer merged patch set 19 03/21/26, 22:24
-
Georg Ringer commented on patch set 19 03/22/26, 20:29
-1 post review, regression https://forge.typo3.org/issues/109315 -
Christian Kuhn commented on patch set 19 03/24/26, 12:21
we missed a resolves line here :/ -
Christian Kuhn commented on patch set 19 03/24/26, 12:22
Reply
Done