93149[TASK] Restructure Toolbar Submenu in TYPO3 page tree
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 2
Files 7
- Build/Sources/Sass/component/_tree.scss+23 −2
- Build/Sources/TypeScript/backend/tree/page-tree-element.ts+91 −21
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+80 −9
- typo3/sysext/backend/Configuration/user.tsconfig6+2 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+6 −3
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-tree-element.js+1 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-109196-DeprecateDoktypesToShowInNewPageDragArea.rstnew+42 −0
Review log 3251
Show 1426 earlier messages
-
Tobias Wojtylak uploaded patch set 1 03/11/26, 10:03
-
core-ci voted on patch set 1 V -1 03/11/26, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97745
-
Tobias Wojtylak uploaded patch set 2
V -103/11/26, 11:23 -
Tobias Wojtylak uploaded patch set 3 03/11/26, 11:40
-
core-ci voted on patch set 3 V -1 03/11/26, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97750
-
core-ci voted on patch set 2 V -1 03/11/26, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97749
-
Tobias Wojtylak rebased onto patch set 4
V -103/12/26, 10:22 -
Tobias Wojtylak rebased onto patch set 5 03/12/26, 10:28
-
core-ci voted on patch set 4 V -1 03/12/26, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97810
-
core-ci voted on patch set 5 V -1 03/12/26, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97813
-
Tobias Wojtylak rebased onto patch set 6
V -103/12/26, 12:10 -
core-ci voted on patch set 6 V -1 03/12/26, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97825
-
Tobias Wojtylak uploaded patch set 7
V -103/12/26, 14:02 -
core-ci voted on patch set 7 V -1 03/12/26, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97832
-
Tobias Wojtylak uploaded patch set 8
V -103/12/26, 14:56 -
core-ci voted on patch set 8 V -1 03/12/26, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97837
-
core-ci commented on patch set 8 03/13/26, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97837
-
Tobias Wojtylak uploaded patch set 9
V -103/13/26, 09:25 -
core-ci voted on patch set 9 V +1 03/13/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97876
-
Tobias Wojtylak uploaded patch set 10
V +103/13/26, 16:13 -
core-ci voted on patch set 10 V +1 03/13/26, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97918
-
Tobias Wojtylak updated the commit message in patch set 11
V +103/16/26, 08:10 -
Tobias Wojtylak marked it ready for review 03/16/26, 08:10
-
Tobias Wojtylak updated the commit message in patch set 12 03/16/26, 08:13
-
Tobias Wojtylak uploaded patch set 13 03/16/26, 08:22
-
core-ci voted on patch set 12 V +1 03/16/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97988
-
core-ci voted on patch set 13 V +1 03/16/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97989
-
core-ci voted on patch set 11 V +1 03/16/26, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97987
-
Tobias Wojtylak marked it ready for review 03/16/26, 10:03
-
Benjamin Kott uploaded patch set 14
V +103/16/26, 12:38 -
core-ci voted on patch set 14 V +1 03/16/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98016
-
Benjamin Kott voted on patch set 14 CR +1 V +1 03/16/26, 12:50
-
Benjamin Franzke voted on patch set 14 CR +1 V +1 03/16/26, 14:06
-
Georg Ringer commented on patch set 14 03/16/26, 15:11
I guess https://review.typo3.org/c/Packages/TYPO3.CMS/+/92730 can be abandoned with that one? -
Georg Ringer commented on patch set 14 CR -1 03/16/26, 15:15
user.tsconfig:13if this setting is not evaluated, please remove it -
Benjamin Franzke commented on patch set 14 03/16/26, 15:32
user.tsconfig:13ReplyIt is checked if the value differs from this default value and only activates the new behavior if no extension explicitly configures available types. It is therefore kept as is for existing `addToList` usages, to be able to add to the default. Do you agree? -
Tobias Wojtylak rebased onto patch set 15
CR +1V +103/16/26, 15:52 -
Benjamin Franzke voted on patch set 15 CR +1 V +1 03/16/26, 15:57
-
core-ci voted on patch set 15 V +1 03/16/26, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98027
-
Georg Ringer commented on patch set 15 03/16/26, 18:26
user.tsconfig:13Replysorry didn't understand that -
Tobias Wojtylak updated the commit message in patch set 16
CR +1V +103/17/26, 07:49 -
Tobias Wojtylak commented on patch set 16 03/17/26, 07:54
user.tsconfig:13Reply@georg.ringer@gmail.com Hello Georg, thanks for your review. Unfortunately, the commit message was not updated during the last update, which may have caused some confusion. I’ve just updated that. The deprecated setting is still evaluated if a value other than the default is configured there. This is handled in the TreeController: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93149/16/typo3/sysext/backend/Classes/Controller/Page/TreeController.php#225 -
core-ci voted on patch set 16 V +1 03/17/26, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98073
-
Tobias Wojtylak updated the commit message in patch set 17
V +103/17/26, 08:19 -
Tobias Wojtylak updated the commit message in patch set 18 03/17/26, 08:20
-
core-ci voted on patch set 17 V +1 03/17/26, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98074
-
core-ci voted on patch set 18 V +1 03/17/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98075
-
Benjamin Franzke commented on patch set 18 CR +1 V +1 03/17/26, 11:20
user.tsconfig:13Replyack, we missed that. Thanks for fixing Tobias! -
Benjamin Kott voted on patch set 18 CR +2 V +2 03/17/26, 13:56
-
Benjamin Kott merged patch set 19 03/17/26, 13:56
-
Benjamin Kott commented on patch set 19 03/17/26, 13:56
user.tsconfig:13ReplyDone