Review main Merged

93149[TASK] Restructure Toolbar Submenu in TYPO3 page tree

Tobias Wojtylak CR +2 V +2 Hard +245 −36 updated 03/17/26, 13:56

Commit message

The toolbar submenu in the TYPO3 page tree has been restructured
to improve usability and modernize the implementation. Initially
visible doktypes are now limited so that they fit within a single
row. A chevron button allows users to expand the submenu and
reveal additional doktypes when needed.

As part of this change, the `doktypesToShowInNewPageDragArea`
TSconfig option has been deprecated and will be removed in v15.

If no custom configuration is defined (the default setup is used),
the available doktypes are now retrieved via the FormDataCompiler,
providing a more consistent way to determine which doktypes are allowed.

If a custom configuration is present, the existing logic will continue
to apply and respect it.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 3251

Show 1426 earlier messages
  1. Tobias Wojtylak uploaded patch set 1 03/11/26, 10:03

  2. core-ci voted on patch set 1 V -1 03/11/26, 10:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97745

  3. Tobias Wojtylak uploaded patch set 2 V -1 03/11/26, 11:23

  4. Tobias Wojtylak uploaded patch set 3 03/11/26, 11:40

  5. core-ci voted on patch set 3 V -1 03/11/26, 11:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97750

  6. core-ci voted on patch set 2 V -1 03/11/26, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97749

  7. Tobias Wojtylak rebased onto patch set 4 V -1 03/12/26, 10:22

  8. Tobias Wojtylak rebased onto patch set 5 03/12/26, 10:28

  9. core-ci voted on patch set 4 V -1 03/12/26, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97810

  10. core-ci voted on patch set 5 V -1 03/12/26, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97813

  11. Tobias Wojtylak rebased onto patch set 6 V -1 03/12/26, 12:10

  12. core-ci voted on patch set 6 V -1 03/12/26, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97825

  13. Tobias Wojtylak uploaded patch set 7 V -1 03/12/26, 14:02

  14. core-ci voted on patch set 7 V -1 03/12/26, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97832

  15. Tobias Wojtylak uploaded patch set 8 V -1 03/12/26, 14:56

  16. core-ci voted on patch set 8 V -1 03/12/26, 15:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97837

  17. core-ci commented on patch set 8 03/13/26, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97837

  18. Tobias Wojtylak uploaded patch set 9 V -1 03/13/26, 09:25

  19. core-ci voted on patch set 9 V +1 03/13/26, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97876

  20. Tobias Wojtylak uploaded patch set 10 V +1 03/13/26, 16:13

  21. core-ci voted on patch set 10 V +1 03/13/26, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97918

  22. Tobias Wojtylak updated the commit message in patch set 11 V +1 03/16/26, 08:10

  23. Tobias Wojtylak marked it ready for review 03/16/26, 08:10

  24. Tobias Wojtylak updated the commit message in patch set 12 03/16/26, 08:13

  25. Tobias Wojtylak uploaded patch set 13 03/16/26, 08:22

  26. core-ci voted on patch set 12 V +1 03/16/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97988

  1. core-ci voted on patch set 13 V +1 03/16/26, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97989

  2. core-ci voted on patch set 11 V +1 03/16/26, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97987

  3. Tobias Wojtylak marked it ready for review 03/16/26, 10:03

  4. Benjamin Kott uploaded patch set 14 V +1 03/16/26, 12:38

  5. core-ci voted on patch set 14 V +1 03/16/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98016

  6. Benjamin Kott voted on patch set 14 CR +1 V +1 03/16/26, 12:50

  7. Benjamin Franzke voted on patch set 14 CR +1 V +1 03/16/26, 14:06

  8. Georg Ringer commented on patch set 14 03/16/26, 15:11

    I guess https://review.typo3.org/c/Packages/TYPO3.CMS/+/92730 can be abandoned with that one?
  9. Georg Ringer commented on patch set 14 CR -1 03/16/26, 15:15

    user.tsconfig:13

    if this setting is not evaluated, please remove it
  10. Benjamin Franzke commented on patch set 14 03/16/26, 15:32

    user.tsconfig:13 Reply

    It is checked if the value differs from this default value and only activates the new behavior if no extension explicitly configures available types. It is therefore kept as is for existing `addToList` usages, to be able to add to the default. Do you agree?
  11. Tobias Wojtylak rebased onto patch set 15 CR +1 V +1 03/16/26, 15:52

  12. Benjamin Franzke voted on patch set 15 CR +1 V +1 03/16/26, 15:57

  13. core-ci voted on patch set 15 V +1 03/16/26, 16:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98027

  14. Georg Ringer commented on patch set 15 03/16/26, 18:26

    user.tsconfig:13 Reply

    sorry didn't understand that
  15. Tobias Wojtylak updated the commit message in patch set 16 CR +1 V +1 03/17/26, 07:49

  16. Tobias Wojtylak commented on patch set 16 03/17/26, 07:54

    user.tsconfig:13 Reply

    @georg.ringer@gmail.com Hello Georg, thanks for your review. Unfortunately, the commit message was not updated during the last update, which may have caused some confusion. I’ve just updated that. The deprecated setting is still evaluated if a value other than the default is configured there. This is handled in the TreeController: https://review.typo3.org/c/Packages/TYPO3.CMS/+/93149/16/typo3/sysext/backend/Classes/Controller/Page/TreeController.php#225
  17. core-ci voted on patch set 16 V +1 03/17/26, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98073

  18. Tobias Wojtylak updated the commit message in patch set 17 V +1 03/17/26, 08:19

  19. Tobias Wojtylak updated the commit message in patch set 18 03/17/26, 08:20

  20. core-ci voted on patch set 17 V +1 03/17/26, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98074

  21. core-ci voted on patch set 18 V +1 03/17/26, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98075

  22. Benjamin Franzke commented on patch set 18 CR +1 V +1 03/17/26, 11:20

    user.tsconfig:13 Reply

    ack, we missed that. Thanks for fixing Tobias!
  23. Benjamin Kott voted on patch set 18 CR +2 V +2 03/17/26, 13:56

  24. Benjamin Kott merged patch set 19 03/17/26, 13:56

  25. Benjamin Kott commented on patch set 19 03/17/26, 13:56

    user.tsconfig:13 Reply

    Done