Review main Merged

93151[BUGFIX] Make orphaned translated records accessible

Benjamin Kott CR +2 V +2 Hard +650 −15 updated 11/10/26, 10:15

Commit message

Records on a page in a language that has no page translation there,
or that the site does not configure at all, cannot be selected in the
language menu of the Layout and Records modules and were therefore not
reachable from the backend anymore.

PageLanguageInformationService::getOrphanedLanguageIds() now detects
these languages for a page: languages of page translations and of
the records the Records module lists, respecting the current
workspace, the user's table and language permissions and the
mod.web_list settings hiding tables or translations. It is only
called by the Layout and Records modules, so other modules building a
page context do not pay for the queries.

Both modules show a flash message naming the site languages the page
has not been translated into, plus a general note for languages the
site does not configure. The Layout module shows it only to users with
access to the Records module, suggests translating the page and points
to the Records module, which lists the affected records of the current
page regardless of the language selection, highlights their rows and
marks the language column, so editors can review and clean up the data.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1217

  1. Benjamin Kott uploaded patch set 1 03/11/26, 12:25

  2. core-ci voted on patch set 1 V -1 03/11/26, 12:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97755

  3. Benjamin Kott uploaded patch set 2 V -1 04/08/26, 14:06

  4. core-ci voted on patch set 2 V +1 04/08/26, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99772

  5. Benni Mack updated the commit message in patch set 3 V +1 04/22/26, 07:28

  6. Benni Mack rebased onto patch set 4 09/30/26, 09:14

  7. core-ci voted on patch set 4 V +1 09/30/26, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109605

  8. Oli Bartsch uploaded patch set 5 V +1 11/10/26, 09:18

  9. Oli Bartsch voted on patch set 5 CR +1 V +1 11/10/26, 09:19

  10. core-ci voted on patch set 5 V +1 11/10/26, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113862

  11. Benni Mack commented on patch set 5 11/10/26, 09:35

    locallang_core.xlf:648

    Can we remove the labels. prefix?
  12. Oli Bartsch uploaded patch set 6 CR +1 V +1 11/10/26, 10:05

  13. Oli Bartsch commented on patch set 6 CR +1 V +1 11/10/26, 10:08

    locallang_core.xlf:648 Reply

    Done
  14. core-ci voted on patch set 6 V +1 11/10/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113867

  15. Benni Mack voted on patch set 6 CR +1 V +1 11/10/26, 10:14

  16. Oli Bartsch voted on patch set 6 CR +2 V +2 11/10/26, 10:15

  17. Oli Bartsch merged patch set 7 11/10/26, 10:15