Review 13.4 Merged

93155[BUGFIX] Exclude disabled form elements from GridRow column class calculation

Josua Vogel CR +2 V +2 Easy +19 −6 updated 03/14/26, 15:58

Commit message

When form elements inside a GridRow are disabled via variants
(renderingOptions.enabled = false), they were still included in the
column class auto-configuration calculation. This caused two issues:

1. Empty <div> elements with col-* classes were rendered for disabled
   elements, creating blank areas next to visible form elements.
2. Visible elements received wrong col-* classes because disabled
   elements were included in the column count calculation.

The fix addresses both problems:

- GridColumnClassAutoConfigurationViewHelper now skips disabled child
  elements when calculating column distribution. It also returns an
  empty string early if the current element itself is disabled.
- The GridRow Fluid template now wraps each column div with an
  <f:if condition="{element.enabled}"> check, so disabled elements
  no longer produce empty wrapper divs.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Josua Vogel uploaded patch set 1 03/12/26, 07:24

  2. Josua Vogel marked it work in progress 03/12/26, 07:25

  3. core-ci voted on patch set 1 V +1 03/12/26, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97795

  4. Georg Ringer commented on patch set 1 03/12/26, 08:36

    This change is ready for review.
  5. Garvin Hicking voted on patch set 1 CR +2 V +2 03/14/26, 15:58

  6. Garvin Hicking merged patch set 2 03/14/26, 15:58