Review main Merged

93158[BUGFIX] Use raw record in preview renderer

Andreas Kienast CR +2 V +2 Easy +9 −5 updated 03/13/26, 16:49

Commit message

The `StandardContentPreviewRenderer` now passed the raw records, if
available, to the preview processor in order to be able to fetch values
by their original field names.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Andreas Kienast uploaded patch set 1 03/12/26, 08:50

  2. Andreas Kienast uploaded patch set 2 03/12/26, 08:51

  3. Andreas Kienast commented on patch set 2 03/12/26, 08:52

    I'm fully aware this isn't an ideal solution, but I have no better idea here.
  4. core-ci voted on patch set 1 V +1 03/12/26, 09:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97802

  5. core-ci voted on patch set 2 V +1 03/12/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97803

  6. Stefan Bürk commented on patch set 2 CR +1 V +1 03/12/26, 12:30

    Reply

    We would check for cababilities and get the data from the system properties of the record and extending the rendering method to deal from there (or doing the fallback there). However, I'd say that the current solution is the better one mainly because it is limited/restricted.
  7. Georg Ringer voted on patch set 2 CR +1 V +1 03/12/26, 19:26

  8. Benni Mack commented on patch set 2 CR +2 V +2 03/13/26, 16:49

    Reply

    For header+footer rendering this solution is very good. The actual better work is to make getProcessedValue() aware of Record API, but then, I would not put this in the BackendUtility anymore either.
  9. Benni Mack merged patch set 3 03/13/26, 16:49