Review main Merged

93159[TASK] Convert InlineControlContainer to web component

Benjamin Kott CR +2 V +2 Normal +78 −75 updated 03/13/26, 09:11

Commit message

Migrate InlineControlContainer from a plain class to an HTMLElement-based
web component. The PHP rendering wraps the container markup in a
<typo3-formengine-container-inline> custom element, and data attributes
are exposed as typed getter properties on the class. The DocumentService
await is removed since connectedCallback already guarantees DOM presence.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Benjamin Kott uploaded patch set 1 03/12/26, 09:39

  2. Benjamin Kott uploaded patch set 2 03/12/26, 09:50

  3. Benjamin Franzke voted on patch set 2 CR +1 V +1 03/12/26, 09:57

  4. core-ci voted on patch set 2 V +1 03/12/26, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97806

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 03/12/26, 10:08

  6. core-ci voted on patch set 1 V +1 03/12/26, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97805

  7. Christian Kuhn voted on patch set 2 CR +1 03/12/26, 22:18

  8. Benjamin Kott voted on patch set 2 CR +2 V +2 03/13/26, 09:11

  9. Benjamin Kott merged patch set 3 03/13/26, 09:11