Review main Merged

9316[BUGFIX] undefined variable imgExt

Simon Schaufelberger CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

reducing colors in getImgResource function fails if not using image-
magic

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Steffen Ritter +1
  • Verified V +2
    • Steffen Ritter +2
    • Tolleiv Nietsch +1

Files 1

Review log 7

  1. Tolleiv Nietsch commented on patch set 1 03/08/12, 11:40

    Verified; Looks good to me, approved "// Normal situation:" gnihihi .... nice catch :)
  2. Steffen Ritter commented on patch set 1 03/08/12, 11:40

    Looks good to me, but someone else must approve
  3. Simon Schaufelberger commented on patch set 1 03/08/12, 11:40

    just as a reminder question: i dont't know if this is the correct solution or if the solution is: $fI = t3lib_div::split_fileref($theImage); $imgExt = (strtolower($fI['fileext']) == $gifCreator->gifExtension ? $gifCreator->gifExtension : 'jpg'); which is missing in the else part.
  4. Simon Schaufelberger commented on patch set 1 03/08/12, 11:40

    i dont't know if this is the correct solution or if the solution is: $fI = t3lib_div::split_fileref($theImage); $imgExt = (strtolower($fI['fileext']) == $gifCreator->gifExtension ? $gifCreator->gifExtension : 'jpg'); which is missing in the else part.
  5. Mr. Jenkins commented on patch set 1 03/08/12, 11:40

  6. Steffen Ritter commented on patch set 1 V 0 03/08/12, 11:40

    by team member
  7. Steffen Ritter merged patch set 1 03/08/12, 11:40