9316[BUGFIX] undefined variable imgExt
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Steffen Ritter +1
-
Verified V +2
- Steffen Ritter +2
- Tolleiv Nietsch +1
Files 1
Review log 7
-
Tolleiv Nietsch commented on patch set 1 03/08/12, 11:40
Verified; Looks good to me, approved "// Normal situation:" gnihihi .... nice catch :) -
Steffen Ritter commented on patch set 1 03/08/12, 11:40
Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 1 03/08/12, 11:40
just as a reminder question: i dont't know if this is the correct solution or if the solution is: $fI = t3lib_div::split_fileref($theImage); $imgExt = (strtolower($fI['fileext']) == $gifCreator->gifExtension ? $gifCreator->gifExtension : 'jpg'); which is missing in the else part. -
Simon Schaufelberger commented on patch set 1 03/08/12, 11:40
i dont't know if this is the correct solution or if the solution is: $fI = t3lib_div::split_fileref($theImage); $imgExt = (strtolower($fI['fileext']) == $gifCreator->gifExtension ? $gifCreator->gifExtension : 'jpg'); which is missing in the else part. -
Mr. Jenkins commented on patch set 1 03/08/12, 11:40
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3481/ : SUCCESS -
Steffen Ritter commented on patch set 1 V 0 03/08/12, 11:40
by team member -
Steffen Ritter merged patch set 1 03/08/12, 11:40