Review main Merged

93160[TASK] Cleanup InlineControlContainer rendering and label usage

Benjamin Kott CR +2 V +2 Normal +48 −61 updated 03/13/26, 14:56

Commit message

Migrate inline configuration (expandSingle, sortable, min, max)
from global JS object to web component data attributes and render
fieldInformation outside the custom element. Replace all LLL:EXT:
language labels with short domain key syntax.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Benjamin Kott uploaded patch set 1 03/12/26, 10:55

  2. Benjamin Kott uploaded patch set 2 03/12/26, 10:56

  3. Benjamin Kott uploaded patch set 3 03/12/26, 11:01

  4. Benjamin Kott uploaded patch set 4 03/12/26, 11:07

  5. core-ci voted on patch set 1 V -1 03/12/26, 11:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97816

  6. core-ci voted on patch set 4 V +1 03/12/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97820

  7. Benjamin Kott uploaded patch set 5 V +1 03/12/26, 11:31

  8. core-ci voted on patch set 5 V +1 03/12/26, 11:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97821

  9. Benjamin Franzke commented on patch set 5 03/12/26, 14:01

    InlineControlContainer.php:450

    Did you check why this previously checked `$groupFieldConfiguration` instead of `$inlineConfiguration`? Has this been nonsense all the time?
  10. Benjamin Franzke commented on patch set 5 03/13/26, 12:18

    InlineControlContainer.php:450 Reply

    Pushed as a separate change as this fixes a real bug: > 93176: [BUGFIX] Fix IRRE usecombination elementBrowserEnabled evaluation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93176
  11. Benjamin Kott uploaded patch set 6 V +1 03/13/26, 14:14

  12. Benjamin Franzke commented on patch set 6 CR +1 V +1 03/13/26, 14:24

    InlineControlContainer.php:278

    Since we're now using a web component (`<typo3-formengine-container-inline>`) we could actually omit `data-`, but i'm fine with using this for now, until we migrate the component to a lit element, where `data-` will be less ideal. Good solution for using `dataset.` for now. No action required.
  13. core-ci voted on patch set 6 V +1 03/13/26, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97905

  14. Josua Vogel voted on patch set 6 CR +1 V +1 03/13/26, 14:48

  15. Benjamin Kott voted on patch set 6 CR +2 V +2 03/13/26, 14:56

  16. Benjamin Kott merged patch set 7 03/13/26, 14:56