Review main Merged

93161[TASK] Cleanup IRRE container implementation details

Benjamin Kott CR +2 V +2 Hard +124 −176 updated 03/16/26, 10:04

Commit message

Convert static methods to instance methods in the
InlineControlContainer web component so that all DOM
queries are scoped to the component element instead of
searching the global document. This is a prerequisite
for reusing InlineControlContainer for both inline
records and file references, where multiple instances
will coexist on the same page.

Replace inline styles with semantic HTML attributes:
use the hidden attribute instead of "display: none" for
toggling button visibility, and replace the
inlineNewButtonStyle CSS string with a boolean
hideNewButton flag.

The redundant $isReadOnly guard on the bottom level
links position can be dropped because read-only state
is already handled earlier: when $isReadOnly is true,
hideNewButton is set which makes the new record button
render with the hidden attribute, and localization
buttons are only rendered for localizable contexts. The
wrapping div therefore contains no actionable controls
in read-only mode regardless of the guard.

The null-coalescing fallbacks on levelLinksPosition are
no longer needed because TcaInlineConfiguration already
guarantees the value is always set to one of "top",
"bottom", or "both".

Adopt the short language key syntax and fix
inconsistent indentation.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1115

  1. Benjamin Kott uploaded patch set 1 03/12/26, 13:39

  2. core-ci voted on patch set 1 V +1 03/12/26, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97829

  3. Benjamin Kott uploaded patch set 2 V +1 03/13/26, 14:14

  4. core-ci voted on patch set 2 V +1 03/13/26, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97906

  5. Benjamin Kott updated the commit message in patch set 3 V +1 03/13/26, 14:56

  6. core-ci voted on patch set 3 V +1 03/13/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97911

  7. Andreas Kienast commented on patch set 3 03/14/26, 15:15

    inline-control-container.ts:837

    Basically, this should do the same (perhaps not the scope of the patch): ``` return this.querySelector<HTMLInputElement>(selector`[name="${this.formField}"]`); ```
  8. Benjamin Kott uploaded patch set 4 V +1 03/16/26, 09:20

  9. Benjamin Kott commented on patch set 4 03/16/26, 09:20

    inline-control-container.ts:837 Reply

    Done
  10. Andreas Kienast voted on patch set 4 CR +1 V +1 03/16/26, 09:43

  11. Benjamin Franzke voted on patch set 4 CR +1 03/16/26, 09:47

  12. core-ci voted on patch set 4 V +1 03/16/26, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97995

  13. Benjamin Franzke voted on patch set 4 V +1 03/16/26, 10:04

  14. Benjamin Kott voted on patch set 4 CR +2 V +2 03/16/26, 10:04

  15. Benjamin Kott merged patch set 5 03/16/26, 10:04