Review main Merged

93166[TASK] Pass HTTP basic auth credentials in server response sub-requests

Georg Ringer CR +2 V +2 Easy +11 −2 updated 09/01/26, 14:37

Commit message

Forward current basic auth credentials to the subrequests created by
`ServerResponseCheck` to avoid false positive reports in the Install Tool
if the TYPO3 installation is using basic authentication.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Garvin Hicking +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Garvin Hicking +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. Georg Ringer uploaded patch set 1 03/12/26, 20:42

  2. Georg Ringer commented on patch set 1 03/12/26, 20:45

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 03/12/26, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97847

  4. Garvin Hicking commented on patch set 1 03/12/26, 21:19

    ServerResponseCheck.php:377

    Set timeout here to prevent the odd-feeling "array add" arithmetic? It kinda itches me 🫣
  5. Benni Mack updated the commit message in patch set 2 V +1 04/22/26, 06:43

  6. core-ci voted on patch set 2 V -1 04/22/26, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100772

  7. Georg Ringer rebased onto patch set 3 V -1 07/05/26, 18:57

  8. core-ci voted on patch set 3 V +1 07/05/26, 19:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104363

  9. Georg Ringer rebased onto patch set 4 V +1 08/27/26, 16:11

  10. core-ci voted on patch set 4 V +1 08/27/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107281

  11. Jörg Bösche voted on patch set 4 CR +1 08/29/26, 20:33

  12. Georg Ringer commented on patch set 4 09/01/26, 07:36

    ServerResponseCheck.php:377 Reply

    Done
  13. Georg Ringer uploaded patch set 5 CR +1 V +1 09/01/26, 08:25

  14. Oliver Klee voted on patch set 5 CR +1 09/01/26, 08:30

  15. core-ci voted on patch set 5 V +1 09/01/26, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107472

  16. Garvin Hicking voted on patch set 5 CR +1 V +1 09/01/26, 08:34

  17. Benni Mack voted on patch set 5 CR +1 V +1 09/01/26, 10:41

  18. Oli Bartsch voted on patch set 5 CR +1 V +1 09/01/26, 14:24

  19. Georg Ringer voted on patch set 5 CR +2 V +2 09/01/26, 14:28

  20. Georg Ringer merged patch set 6 09/01/26, 14:37