Review main Merged

93169[TASK] Reuse InlineControlContainer for file references

Benjamin Kott CR +2 V +2 Hard +85 −826 updated 03/16/26, 18:59

Commit message

The FilesControlContainer TypeScript was largely a duplicate of
InlineControlContainer. Instead of maintaining two parallel
implementations, the PHP side is aligned to emit the same DOM
structure and CSS classes that InlineControlContainer expects.

Both containers now share the typo3-formengine-container-inline
web component. Endpoint routing is determined by a new
data-type attribute. Button visibility uses the hidden
attribute instead of inline styles to stay compatible with the
existing toggle mechanism. The standalone
files-control-container.ts is removed.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 914

  1. Benjamin Kott uploaded patch set 1 03/12/26, 23:44

  2. core-ci voted on patch set 1 V -1 03/12/26, 23:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97852

  3. Benjamin Kott rebased onto patch set 2 V -1 03/13/26, 14:14

  4. core-ci voted on patch set 2 V -1 03/13/26, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97908

  5. Benjamin Kott uploaded patch set 3 V -1 03/16/26, 09:20

  6. core-ci voted on patch set 3 V -1 03/16/26, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97997

  7. Benjamin Kott uploaded patch set 4 V -1 03/16/26, 10:31

  8. core-ci voted on patch set 4 V +1 03/16/26, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98004

  9. Benjamin Franzke updated the commit message in patch set 5 V +1 03/16/26, 14:19

  10. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/16/26, 14:20

  11. core-ci voted on patch set 5 V +1 03/16/26, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98022

  12. Andreas Nedbal voted on patch set 5 CR +1 V +1 03/16/26, 14:43

  13. Benjamin Kott voted on patch set 5 CR +2 V +2 03/16/26, 18:59

  14. Benjamin Kott merged patch set 6 03/16/26, 18:59