9317[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Susi Moog +1
-
Verified V +2
- Steffen Ritter +2
- Susi Moog +1
Files 1
Review log 12
-
Susi Moog uploaded patch set 2 03/12/12, 16:28
-
Susi Moog commented on patch set 2 03/12/12, 16:28
Verified; Looks good to me, but someone else must approve Wouter, you can always fix the regression directly in the bug if it's not already merged. I integrated the regression fix here, so there is no chance that it will be forgotten. -
Xavier Perseguers commented on patch set 2 03/12/12, 16:28
Wouter, I do not understand your comment in the other patch (https://review.typo3.org/#/c/9519/). I'm about to merge the other one into all branches. I guess this very patch should simply be abandonned. -
Xavier Perseguers commented on patch set 2 03/12/12, 16:28
Other patch cannot be applied due to conflict. As such, Wouter, can you please see and adapt the patch to be applied? Thanks. -
Georg Ringer commented on patch set 2 03/12/12, 16:28
Verified; Looks good to me, but someone else must approve -
Wouter Wolters commented on patch set 1 03/12/12, 16:28
When this patch and https://review.typo3.org/#change,9319 are merged I will also submit the patch (https://review.typo3.org/#change,9281) that will fix a regression in this patch. Or is there another way to solve this regression for 4.6 and 4.5? -
Wouter Wolters commented on patch set 2 03/12/12, 16:28
Xavier, I will merge the patch and come up with a new one. There is a conflict because this patch isn't included so the other patches can't be applied -
Susi Moog commented on patch set 3 03/12/12, 16:28
Verified; Looks good to me, but someone else must approve With this patch 4.5 gets exactly the same code as 4.6 and above already have. -
Steffen Ritter commented on patch set 3 03/12/12, 16:28
Looks good to me, approved -
Wouter Wolters uploaded patch set 3 03/12/12, 16:28
-
Steffen Ritter commented on patch set 3 V 0 03/12/12, 16:28
by team member -
Steffen Ritter merged patch set 3 03/12/12, 16:28