Review main Merged

93170[TASK] Reuse InlineControlContainer for site language records

Benjamin Kott CR +2 V +2 Hard +93 −686 updated 03/17/26, 10:20

Commit message

The SiteLanguageContainer TypeScript was largely a duplicate of
InlineControlContainer. Instead of maintaining two parallel
implementations, the PHP and Fluid side are aligned to use the
typo3-formengine-container-inline web component directly.

Endpoint routing is handled via the data-foreign-table attribute.
The preset selector for creating language records from predefined
configurations is now a generic feature of InlineControlContainer.
Endpoints that are not available for a given foreign table, such
as synchronize/localize and expand/collapse state persistence,
are nullable and result in a no-op. The standalone
site-language-container.ts is removed.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 914

  1. Benjamin Kott uploaded patch set 1 03/13/26, 00:01

  2. core-ci voted on patch set 1 V -1 03/13/26, 00:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97853

  3. Benjamin Kott rebased onto patch set 2 V -1 03/13/26, 14:14

  4. core-ci voted on patch set 2 V -1 03/13/26, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97909

  5. Benjamin Kott uploaded patch set 3 V -1 03/16/26, 09:20

  6. core-ci voted on patch set 3 V -1 03/16/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97998

  7. Benjamin Kott uploaded patch set 4 V -1 03/16/26, 10:39

  8. core-ci voted on patch set 4 V +1 03/16/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98005

  9. Benjamin Kott rebased onto patch set 5 V +1 03/16/26, 19:01

  10. core-ci voted on patch set 5 V +1 03/16/26, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98042

  11. Andreas Nedbal voted on patch set 5 CR +1 V +1 03/17/26, 08:12

  12. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/17/26, 10:20

  13. Benjamin Kott voted on patch set 5 CR +2 V +2 03/17/26, 10:20

  14. Benjamin Kott merged patch set 6 03/17/26, 10:20