Review main Merged

93171[TASK] Migrate inline record panels to Bootstrap Collapse

Benjamin Kott CR +2 V +2 Expert +1035 −385 updated 03/18/26, 07:16

Commit message

Inline record panels (IRRE, file references, flex form containers)
previously relied on custom panel-visible/panel-collapsed classes and
manual JavaScript toggle logic. This switches to Bootstrap's native
Collapse component with data-bs-toggle attributes and .collapse/.show
classes, replacing the custom state management entirely.

Panel heading markup is updated from form-irre-header-* classes to
standard panel component classes (panel-button, panel-heading-row,
panel-title, panel-icon, panel-actions). The TypeScript side now listens
to Bootstrap collapse events instead of delegating click handlers,
separating toggle behavior from state persistence. The legacy
form-irre-header CSS is removed as it is no longer referenced.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Markus Klein +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 25

Show 5 more files

Review log 2334

Show 59 earlier messages
  1. Benjamin Kott uploaded patch set 1 03/13/26, 02:07

  2. core-ci voted on patch set 1 V -1 03/13/26, 02:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97857

  3. Benjamin Kott uploaded patch set 2 V -1 03/13/26, 09:00

  4. core-ci voted on patch set 2 V -1 03/13/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97875

  5. Benjamin Kott rebased onto patch set 3 V -1 03/13/26, 14:14

  6. core-ci voted on patch set 3 V -1 03/13/26, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97910

  7. Benjamin Kott uploaded patch set 4 V -1 03/16/26, 09:20

  8. core-ci voted on patch set 4 V -1 03/16/26, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97999

  9. Benjamin Kott uploaded patch set 5 V -1 03/16/26, 10:39

  1. core-ci voted on patch set 5 V -1 03/16/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98006

  2. Benjamin Kott uploaded patch set 6 V -1 03/16/26, 16:38

  3. core-ci voted on patch set 6 V -1 03/16/26, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98035

  4. Benjamin Kott uploaded patch set 7 V -1 03/16/26, 19:01

  5. core-ci voted on patch set 7 V -1 03/16/26, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98043

  6. Benjamin Kott uploaded patch set 8 V -1 03/16/26, 23:21

  7. core-ci voted on patch set 8 V -1 03/16/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98056

  8. Benjamin Kott uploaded patch set 9 V -1 03/16/26, 23:43

  9. core-ci voted on patch set 9 V +1 03/16/26, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98057

  10. Benjamin Franzke uploaded patch set 10 V +1 03/17/26, 11:08

  11. core-ci voted on patch set 10 V +1 03/17/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98087

  12. Benjamin Franzke voted on patch set 10 CR +1 V +1 03/17/26, 11:18

  13. Markus Klein commented on patch set 10 03/17/26, 12:42

    FileReferenceContainer.php:226

    should we hsc() all usages of this $objectId?
  14. Oli Bartsch commented on patch set 10 03/17/26, 13:40

    Just curious: aren’t we in the process of removing Bootstrap usage across the core?
  15. Benjamin Kott commented on patch set 10 03/17/26, 13:54

    Reply

    Yes we are, with this patch we align the behavior in this area while also correcting the outstanding styling issues in that area. This allows easier extraction later on.
  16. Benjamin Kott uploaded patch set 11 CR +1 V +1 03/17/26, 15:09

  17. Benjamin Kott commented on patch set 11 03/17/26, 15:12

    FileReferenceContainer.php:226 Reply

    this part was not changed and just moved. but i checked with the inline record container and it seems that objectid was also hsc() there, so i aligned it.
  18. core-ci voted on patch set 11 V +1 03/17/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98097

  19. Markus Klein voted on patch set 11 CR +1 03/17/26, 18:53

  20. Georg Ringer voted on patch set 11 CR +1 V +1 03/17/26, 20:59

  21. Benjamin Franzke voted on patch set 11 CR +1 V +1 03/18/26, 03:41

  22. Josua Vogel voted on patch set 11 CR +1 V +1 03/18/26, 06:32

  23. Georg Ringer voted on patch set 11 CR +2 V +2 03/18/26, 06:40

  24. Benjamin Kott commented on patch set 11 CR +2 V +2 03/18/26, 07:16

    Reply

    Done
  25. Benjamin Kott merged patch set 12 03/18/26, 07:16