93171[TASK] Migrate inline record panels to Bootstrap Collapse
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Kott +2
- Benjamin Franzke +1
- Markus Klein +1
- Josua Vogel +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Kott +2
- Benjamin Franzke +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 25
- Build/Sources/Sass/component/_panel.scss+53 −14
- Build/Sources/Sass/element/typo3-formengine-container-inline.scssnew+10 −0
- Build/Sources/Sass/typo3/_contextual_record_edit.scss+4 −27
- Build/Sources/Sass/typo3/_main_form.scss+0 −54
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+38 −29
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-section-container.ts+8 −27
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+96 −108
- Build/tests/playwright/e2e/setup/setup-module.spec.ts+1 −1
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php2+46 −43
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+14 −14
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −2
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+18 −20
- typo3/sysext/backend/Resources/Private/Templates/Form/FilesControlContainer.fluid.html+4 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+20 −26
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-section-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+4 −4
Show 5 more files
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FileCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+5 −5
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/NullPlaceholderCest.php+1 −1
- typo3/sysext/styleguide/Resources/Private/Language/locallang.xlf+9 −0
- typo3/sysext/styleguide/Resources/Private/Templates/Backend/Components/Panels.fluid.html+696 −0
Review log 2334
Show 59 earlier messages
-
Benjamin Kott uploaded patch set 1 03/13/26, 02:07
-
core-ci voted on patch set 1 V -1 03/13/26, 02:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97857
-
Benjamin Kott uploaded patch set 2
V -103/13/26, 09:00 -
core-ci voted on patch set 2 V -1 03/13/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97875
-
Benjamin Kott rebased onto patch set 3
V -103/13/26, 14:14 -
core-ci voted on patch set 3 V -1 03/13/26, 14:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97910
-
Benjamin Kott uploaded patch set 4
V -103/16/26, 09:20 -
core-ci voted on patch set 4 V -1 03/16/26, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97999
-
Benjamin Kott uploaded patch set 5
V -103/16/26, 10:39
-
core-ci voted on patch set 5 V -1 03/16/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98006
-
Benjamin Kott uploaded patch set 6
V -103/16/26, 16:38 -
core-ci voted on patch set 6 V -1 03/16/26, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98035
-
Benjamin Kott uploaded patch set 7
V -103/16/26, 19:01 -
core-ci voted on patch set 7 V -1 03/16/26, 19:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98043
-
Benjamin Kott uploaded patch set 8
V -103/16/26, 23:21 -
core-ci voted on patch set 8 V -1 03/16/26, 23:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98056
-
Benjamin Kott uploaded patch set 9
V -103/16/26, 23:43 -
core-ci voted on patch set 9 V +1 03/16/26, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98057
-
Benjamin Franzke uploaded patch set 10
V +103/17/26, 11:08 -
core-ci voted on patch set 10 V +1 03/17/26, 11:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98087
-
Benjamin Franzke voted on patch set 10 CR +1 V +1 03/17/26, 11:18
-
Markus Klein commented on patch set 10 03/17/26, 12:42
-
Oli Bartsch commented on patch set 10 03/17/26, 13:40
Just curious: aren’t we in the process of removing Bootstrap usage across the core? -
Benjamin Kott commented on patch set 10 03/17/26, 13:54
Reply
Yes we are, with this patch we align the behavior in this area while also correcting the outstanding styling issues in that area. This allows easier extraction later on. -
Benjamin Kott uploaded patch set 11
CR +1V +103/17/26, 15:09 -
Benjamin Kott commented on patch set 11 03/17/26, 15:12
FileReferenceContainer.php:226Replythis part was not changed and just moved. but i checked with the inline record container and it seems that objectid was also hsc() there, so i aligned it. -
core-ci voted on patch set 11 V +1 03/17/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98097
-
Markus Klein voted on patch set 11 CR +1 03/17/26, 18:53
-
Georg Ringer voted on patch set 11 CR +1 V +1 03/17/26, 20:59
-
Benjamin Franzke voted on patch set 11 CR +1 V +1 03/18/26, 03:41
-
Josua Vogel voted on patch set 11 CR +1 V +1 03/18/26, 06:32
-
Georg Ringer voted on patch set 11 CR +2 V +2 03/18/26, 06:40
-
Benjamin Kott commented on patch set 11 CR +2 V +2 03/18/26, 07:16
Reply
Done -
Benjamin Kott merged patch set 12 03/18/26, 07:16
FileReferenceContainer.php:226