Review main Abandoned

93174[FEATURE] Add TCA configuration for dynamic page creation wizard steps

Bastien Lutz CR 0 V 0 Hard +417 −90 updated 03/23/26, 07:53

Commit message

The page creation wizard now supports a dynamic configuration
for its steps via TCA.
This allows defining which fields are displayed in which step of the wizard.
For this the type-specific configuration key `wizardSteps` is used.

If required fields are missing in the configuration, they are automatically displayed in an additional last step.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 6

Review log 2133

Show 58 earlier messages
  1. Bastien Lutz uploaded patch set 1 03/13/26, 09:33

  2. Bastien Lutz marked it work in progress 03/13/26, 09:34

  3. core-ci voted on patch set 1 V -1 03/13/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97877

  4. Bastien Lutz uploaded patch set 2 V -1 03/16/26, 10:18

  5. core-ci voted on patch set 2 V -1 03/16/26, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98003

  6. Bastien Lutz rebased onto patch set 3 V -1 03/16/26, 15:07

  7. core-ci voted on patch set 3 V -1 03/16/26, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98025

  8. Bastien Lutz uploaded patch set 4 V -1 03/16/26, 15:45

  1. core-ci voted on patch set 4 V -1 03/16/26, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98026

  2. Bastien Lutz uploaded patch set 5 V -1 03/17/26, 10:17

  3. core-ci voted on patch set 5 V -1 03/17/26, 10:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98084

  4. Bastien Lutz uploaded patch set 6 V -1 03/17/26, 10:39

  5. core-ci voted on patch set 6 V -1 03/17/26, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98085

  6. Bastien Lutz uploaded patch set 7 V -1 03/17/26, 13:23

  7. Bastien Lutz marked it ready for review 03/17/26, 13:23

  8. core-ci voted on patch set 7 V -1 03/17/26, 13:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98092

  9. Bastien Lutz rebased onto patch set 8 V -1 03/18/26, 15:25

    The following files contain Git conflicts: * typo3/sysext/backend/Classes/Wizard/PageWizardProvider.php
  10. core-ci voted on patch set 8 V -1 03/18/26, 16:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98206

  11. Benjamin Franzke uploaded patch set 9 V -1 03/19/26, 12:11

    Resolve Merge-Conflicts
  12. core-ci voted on patch set 9 V -1 03/19/26, 12:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98230

  13. Garvin Hicking commented on patch set 9 03/19/26, 19:35

    I'm commenting here because I'm not sure where in the relation chain a general feedback to this fits. Hope that's fine to use this here as an entry point as Benji linked to it. Kudos for all it, that looks quite smooth and a lot of work! I only tested a few things, but they all worked quite well. I was quite relieved to see drag+drop is still there, because I afraid it was (is?) on the chopping block. However, I must say I don't love the fact how draging+dropping a page now needs to: - drop the page - focus the page title input field (I can't directly start typing like before) unfocus the page title (because otherwise the 'NEXT' button is not active) - Click 3 times on a button (Next step -> confirm -> finish) until the page is there Is there a plan to maybe adress this? Like "press enter on the pagetitle and everything submits at once"? Or a "Quick finish" button? And put focus on the page title field directly? I'm not sure if that is part of future streamlining, but I really liked to have a dropped page immediately be inside the page tree so that I can rapidly fill a page tree. v13 did have that annoying oddity that it performed a lot of reloads in the content frame, and left the input focus on the tree, forcing you to reclick. So I was more hoping that might be salvageable 😄 Another small thing: The font size in the wizard panel headers (now that I have a panel with many more entries than curren usages of that component) feels a bit off. The font itself to me looks differently at that scaling than the rest of the UI modal and creates a visual imbalance to me - between 14px and 16px that makes a quite noticable difference. The h4 in the modal to me would make it look more organic. Just a side note though, not wanting to really get into the UI thing here but I had to mention my feelings.
  14. Garvin Hicking commented on patch set 9 03/19/26, 19:40

    PageWizardStepBuilder.php:37

    This is public API, right? So we'll document this in the TYPO3 Docs, right?

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:14

    ```suggestion The page creation wizard now supports a dynamic configuration ```

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:26

    ```suggestion configured wizard step, a fallback step name is automatically appended at the end. ```
  15. Bastien Lutz uploaded patch set 10 V -1 03/20/26, 08:56

  16. Bastien Lutz commented on patch set 9 03/20/26, 08:58

    This change is ready for review.

    PageWizardStepBuilder.php:37 Reply

    Done

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:14 Reply

    Done

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:26 Reply

    Done
  17. Bastien Lutz marked it ready for review 03/20/26, 08:58

  18. Bastien Lutz rebased onto patch set 11 03/20/26, 09:03

  19. core-ci voted on patch set 10 V -1 03/20/26, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98275

  20. core-ci voted on patch set 11 V +1 03/20/26, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98278

  21. Garvin Hicking commented on patch set 11 03/20/26, 12:25

    Reply

    I discussed this with Benjamin and Benjamin (but not Benjamin) today. My main concern about the "quickness" of the wizard is now addressed here: https://forge.typo3.org/issues/109303 I think this is well suitable as a follow-up for later addressing and should not block this. Also as Benjamins explained, the current "error focus" will be addressed, so that hitting enter consecutively multiple times will increase velocity. Thus I consider my comments here resolved/addressed.
  22. Bastien Lutz rebased onto patch set 12 V +1 03/20/26, 13:41

  23. core-ci voted on patch set 12 V +1 03/20/26, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98294

  24. Georg Ringer commented on patch set 12 03/20/26, 20:32

    Feature-109271-TCAConfigurationForDynamicWizardSteps.rst:39 Unresolved

    could we use the new syntax here, like already in tca/pages.php?
  25. Bastien Lutz abandoned the change 03/23/26, 07:53

    Squashed into: 93290: [FEATURE] Implement page creation wizard | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93290