93175[BUGFIX] Fix child UID resolution for type=group in useCombination
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1011
-
Benjamin Kott uploaded patch set 1 03/13/26, 12:15
-
core-ci voted on patch set 1 V +1 03/13/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97888
-
Garvin Hicking commented on patch set 1 03/13/26, 13:28
Did not check but does it affect 13.4 too and we should fix it? -
Benjamin Kott commented on patch set 1 03/13/26, 13:42
Reply
i pinged @lolli@schwarzbu.ch i have no idea when what was changed here, could only pinpoint the problem -
Benjamin Kott commented on patch set 1 03/13/26, 13:50
Reply
we only stumbled over this by checking since i was working on the irre normalization 93176: [BUGFIX] Fix IRRE usecombination elementBrowserEnabled evaluation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93176 -
Garvin Hicking commented on patch set 1 03/16/26, 08:04
Reply
I'd like to test this with v13, could you give instructions how to easily verify this bugfix? Is there a Styleguide TCA definition I can use for testing? -
Benjamin Kott commented on patch set 1 03/16/26, 08:17
Reply
its `inline usecombinationgroup` in styleguide -
Garvin Hicking commented on patch set 1 CR +1 V +1 03/16/26, 08:57
Reply
Thanks. Could reproduce the bug and this fix in main. Could not reproduce the problem in main, so that case should be closed. -
Benjamin Franzke voted on patch set 1 CR +1 V +1 03/16/26, 09:22
-
Benjamin Kott voted on patch set 1 CR +2 V +2 03/16/26, 09:22
-
Benjamin Kott merged patch set 2 03/16/26, 09:22