Review main Merged

93175[BUGFIX] Fix child UID resolution for type=group in useCombination

Benjamin Kott CR +2 V +2 Easy +4 −2 updated 03/16/26, 09:22

Commit message

The compileChildChild() method assumed the foreign_selector
field is always type=select, where databaseRow resolves to a
flat array of UIDs. For type=group fields, TcaGroup resolves
to an array of associative arrays containing 'table', 'uid',
etc. Accessing [0] returned the full array, and casting it to
(int) always yielded 1, causing TYPO3 to look up the wrong
child record.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1011

  1. Benjamin Kott uploaded patch set 1 03/13/26, 12:15

  2. core-ci voted on patch set 1 V +1 03/13/26, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97888

  3. Garvin Hicking commented on patch set 1 03/13/26, 13:28

    Did not check but does it affect 13.4 too and we should fix it?
  4. Benjamin Kott commented on patch set 1 03/13/26, 13:42

    Reply

    i pinged @lolli@schwarzbu.ch i have no idea when what was changed here, could only pinpoint the problem
  5. Benjamin Kott commented on patch set 1 03/13/26, 13:50

    Reply

    we only stumbled over this by checking since i was working on the irre normalization 93176: [BUGFIX] Fix IRRE usecombination elementBrowserEnabled evaluation | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93176
  6. Garvin Hicking commented on patch set 1 03/16/26, 08:04

    Reply

    I'd like to test this with v13, could you give instructions how to easily verify this bugfix? Is there a Styleguide TCA definition I can use for testing?
  7. Benjamin Kott commented on patch set 1 03/16/26, 08:17

    Reply

    its `inline usecombinationgroup` in styleguide
  8. Garvin Hicking commented on patch set 1 CR +1 V +1 03/16/26, 08:57

    Reply

    Thanks. Could reproduce the bug and this fix in main. Could not reproduce the problem in main, so that case should be closed.
  9. Benjamin Franzke voted on patch set 1 CR +1 V +1 03/16/26, 09:22

  10. Benjamin Kott voted on patch set 1 CR +2 V +2 03/16/26, 09:22

  11. Benjamin Kott merged patch set 2 03/16/26, 09:22