Review main Merged

93179[TASK] Re-add and deprecate FormResultCompiler

Andreas Nedbal CR +2 V +2 Hard +257 −1 updated 03/14/26, 08:20

Commit message

While internal, FormResultCompiler is used in a lot of
community extensions to render FormEngine forms manually.

In order to not break these extensions, the class (which
has no usages in the core anymore) has been re-added for
compatibility, but also marked deprecated with an
appropriate notice and migration guide.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 812

  1. Andreas Nedbal uploaded patch set 1 03/13/26, 13:07

  2. Garvin Hicking commented on patch set 1 03/13/26, 13:11

    we should then add this to the extension scanner for usages and deprecations. thanks!
  3. core-ci voted on patch set 1 V -1 03/13/26, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97897

  4. Andreas Nedbal uploaded patch set 2 V -1 03/13/26, 13:22

  5. Andreas Nedbal commented on patch set 2 03/13/26, 13:22

    Reply

    Done
  6. core-ci voted on patch set 2 V -1 03/13/26, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97900

  7. Andreas Nedbal uploaded patch set 3 V -1 03/13/26, 13:47

  8. core-ci voted on patch set 3 V -1 03/13/26, 14:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97901

  9. core-ci voted on patch set 3 V +1 03/13/26, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97901

  10. Garvin Hicking voted on patch set 3 CR +1 V +1 03/13/26, 20:45

  11. Georg Ringer voted on patch set 3 CR +2 V +2 03/14/26, 08:20

  12. Georg Ringer merged patch set 4 03/14/26, 08:20