93186[TASK] Migrate EXT:form tree-component-adapter from jQuery to Vanilla JS
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/form/backend/form-editor/mediator.ts+2 −2
- Build/Sources/TypeScript/form/backend/form-editor/tree-component-adapter.ts+46 −38
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+41 −40
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/tree-component-adapter.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
Review log 1014
-
Josua Vogel uploaded patch set 1 03/14/26, 14:29
-
core-ci voted on patch set 1 V +1 03/14/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97944
-
Josua Vogel rebased onto patch set 2
V +103/16/26, 14:18 -
core-ci voted on patch set 2 V +1 03/16/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98021
-
Benjamin Franzke commented on patch set 2 03/18/26, 04:30
helper.ts:213It seems this patch does not use the new methods at all, they are first used with > 93187: [TASK] Migrate EXT:form from jQuery to Vanilla JS - modals, mediator and view-model | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93187 I think we should move this helper.ts part into that patch. do you agree? -
Benjamin Franzke uploaded patch set 3
V +103/18/26, 04:39 -
Benjamin Franzke commented on patch set 3 03/18/26, 04:39
helper.ts:211ReplyDone (in next patch in relation chain).helper.ts:213ReplyDone -
Benjamin Franzke rebased onto patch set 4 03/18/26, 05:06
-
Benjamin Franzke voted on patch set 4 CR +1 V +1 03/18/26, 05:06
-
core-ci voted on patch set 3 V +1 03/18/26, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98126
-
core-ci voted on patch set 4 V +1 03/18/26, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98131
-
Benjamin Kott voted on patch set 4 CR +1 V +1 03/18/26, 08:29
-
Benjamin Kott voted on patch set 4 CR +2 V +2 03/18/26, 08:50
-
Benjamin Kott merged patch set 5 03/18/26, 08:50
helper.ts:211