Review main Merged

93186[TASK] Migrate EXT:form tree-component-adapter from jQuery to Vanilla JS

Josua Vogel CR +2 V +2 Normal +91 −82 updated 03/18/26, 08:50

Commit message

Remove jQuery dependency from `form-editor/tree-component-adapter.ts` as
part of the ongoing jQuery removal in the Form Backend.

`tree-component-adapter.ts` is fully migrated.
Cascading fixes in dependent files to keep the build green.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1014

  1. Josua Vogel uploaded patch set 1 03/14/26, 14:29

  2. core-ci voted on patch set 1 V +1 03/14/26, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97944

  3. Josua Vogel rebased onto patch set 2 V +1 03/16/26, 14:18

  4. core-ci voted on patch set 2 V +1 03/16/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98021

  5. Benjamin Franzke commented on patch set 2 03/18/26, 04:30

    helper.ts:211

    We can no deprecate, sice we still use it. We can change this to a @todo instead.

    helper.ts:213

    It seems this patch does not use the new methods at all, they are first used with > 93187: [TASK] Migrate EXT:form from jQuery to Vanilla JS - modals, mediator and view-model | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93187 I think we should move this helper.ts part into that patch. do you agree?
  6. Benjamin Franzke uploaded patch set 3 V +1 03/18/26, 04:39

  7. Benjamin Franzke commented on patch set 3 03/18/26, 04:39

    helper.ts:211 Reply

    Done (in next patch in relation chain).

    helper.ts:213 Reply

    Done
  8. Benjamin Franzke rebased onto patch set 4 03/18/26, 05:06

  9. Benjamin Franzke voted on patch set 4 CR +1 V +1 03/18/26, 05:06

  10. core-ci voted on patch set 3 V +1 03/18/26, 05:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98126

  11. core-ci voted on patch set 4 V +1 03/18/26, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98131

  12. Benjamin Kott voted on patch set 4 CR +1 V +1 03/18/26, 08:29

  13. Benjamin Kott voted on patch set 4 CR +2 V +2 03/18/26, 08:50

  14. Benjamin Kott merged patch set 5 03/18/26, 08:50