Review main Merged

93187[TASK] Migrate modals, mediator and view-model in EXT:form to Vanilla JS

Josua Vogel CR +2 V +2 Hard +218 −151 updated 03/18/26, 10:47

Commit message

Remove jQuery dependency from `form-editor/modals-component.ts`,
`form-editor/mediator.ts` and complete the migration of
`form-editor/view-model.ts` as part of the ongoing jQuery removal in
the Form Backend.

New native methods are introduced in helper.ts alongside (to-be-removed)
jQuery-returning counterparts to allow incremental, always-compilable
migration:

- Add `getTemplateElement(): HTMLTemplateElement | null` as native
  replacement for `getTemplate(): JQuery`
- Add `getTemplatePropertyElement(): HTMLElement | null` as native
  replacement for `getTemplatePropertyDomElement(): JQuery`

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1016

  1. Josua Vogel uploaded patch set 1 03/14/26, 14:59

  2. core-ci voted on patch set 1 V -1 03/14/26, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97945

  3. Benjamin Franzke uploaded patch set 2 V -1 03/18/26, 04:39

  4. core-ci voted on patch set 2 V +1 03/18/26, 04:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98127

  5. Benjamin Franzke rebased onto patch set 3 V +1 03/18/26, 05:06

  6. core-ci voted on patch set 3 V -1 03/18/26, 05:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98132

  7. core-ci commented on patch set 3 03/18/26, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98132

  8. Benjamin Franzke commented on patch set 3 CR -1 03/18/26, 09:15

    modals-component.ts:345

    We actually do not need to create a temporary div and evaluate innerHTML, since we already migrated all templates to `<template>` tags and can therefore use the `DocumentFragment` and pass that to the modal API (which is also already prepared for passing document fragments as content). Will adapt the patch accordingly.
  9. Benjamin Franzke uploaded patch set 4 CR -1 V -1 03/18/26, 09:34

  10. Benjamin Franzke commented on patch set 4 03/18/26, 09:34

    modals-component.ts:345 Reply

    Done
  11. Benjamin Franzke voted on patch set 4 CR +1 V +1 03/18/26, 09:35

  12. core-ci voted on patch set 4 V -1 03/18/26, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98158

  13. core-ci voted on patch set 4 V +1 03/18/26, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98158

  14. Benjamin Kott voted on patch set 4 CR +1 V +1 03/18/26, 10:18

  15. Benjamin Franzke voted on patch set 4 CR +2 V +2 03/18/26, 10:29

  16. Benjamin Franzke merged patch set 5 03/18/26, 10:47