Review main Merged

93188[TASK] Migrate stage component in EXT:form to Vanilla JS

Josua Vogel CR +2 V +2 Hard +287 −263 updated 03/20/26, 08:37

Commit message

Remove jQuery from stage-component.ts

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1824

  1. Josua Vogel uploaded patch set 1 03/14/26, 15:17

  2. core-ci voted on patch set 1 V +1 03/14/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97946

  3. Benjamin Franzke rebased onto patch set 2 V +1 03/18/26, 05:06

  4. core-ci voted on patch set 2 V +1 03/18/26, 05:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98133

  5. Josua Vogel rebased onto patch set 3 V +1 03/18/26, 11:07

  6. core-ci voted on patch set 3 V +1 03/18/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98166

  7. Benjamin Franzke commented on patch set 3 CR -1 03/18/26, 12:07

    stage-component.ts:179

  8. Josua Vogel uploaded patch set 4 CR -1 V +1 03/18/26, 12:25

  9. Josua Vogel commented on patch set 4 03/18/26, 12:25

    stage-component.ts:179 Reply

    Done
  10. core-ci voted on patch set 4 V -1 03/18/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98182

  11. core-ci voted on patch set 4 V +1 03/18/26, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98182

  12. Benjamin Franzke commented on patch set 4 V -1 03/19/26, 07:41

    stage-component.ts:179

    Using the first element only, causes template parts that contain multiple elements to be cropped. e.g. given the following example: ``` <template> <h2>…</h2> <div>…</div> </template ``` Only `h2` would be selected and `div` ignored. (I found at least one usecase with the linked checkbox extension) I'll fix.
  13. Benjamin Franzke uploaded patch set 5 V +1 03/19/26, 08:13

  14. Benjamin Franzke commented on patch set 5 03/19/26, 08:13

    stage-component.ts:179 Reply

    Done
  15. Benjamin Franzke voted on patch set 5 CR +1 V +1 03/19/26, 08:13

  16. core-ci voted on patch set 5 V +1 03/19/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98226

  17. Andreas Kienast commented on patch set 5 03/19/26, 09:37

    Several exported functions in stage-component.ts are considered unused (were already before this patch). Are those left-overs or kept for bc reasons?

    stage-component.ts:1044

    Would it make sense to officially deprecate this, or is this planned for another patch?
  18. Josua Vogel commented on patch set 5 03/19/26, 09:52

    stage-component.ts:1044 Reply

    Yes, I want to deprecate those functions in a separate patch 😊
  19. Benjamin Franzke commented on patch set 5 03/19/26, 09:52

    stage-component.ts:1044 Reply

    Can you name them? Maybe the IDE is confused by constructs like ``` import * as StageComponent from '@typo3/form/backend/form-editor/stage-component'; // … export function getStage(): typeof StageComponent { return stageComponent; } // … getStage().getStagePanelDomElement() ``` So that the usage (in this case of `getStagePanelDomElement()`) is not tracked?
  20. Benjamin Franzke commented on patch set 5 03/19/26, 09:53

    stage-component.ts:1044 Reply

    ah, ok, Josua already confirmed.
  21. Josua Vogel commented on patch set 5 03/19/26, 09:59

    stage-component.ts:1044 Reply

    Yes, most render functions should be deprecated, because I introduced a web component. Extensions might use those methods, so we need to deprecate them. Those extensions can use the web component or implement a custom rendering. But I would do this in a separate patch
  22. Josua Vogel commented on patch set 5 03/20/26, 06:42

    stage-component.ts:1044 Reply

    resolve
  23. Andreas Kienast voted on patch set 5 CR +2 V +2 03/20/26, 08:37

  24. Andreas Kienast merged patch set 6 03/20/26, 08:37