93188[TASK] Migrate stage component in EXT:form to Vanilla JS
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/form/backend/form-editor/mediator.ts+4 −4
- Build/Sources/TypeScript/form/backend/form-editor/stage-component.ts10+256 −235
- Build/Sources/TypeScript/form/backend/form-editor/view-model.ts+25 −22
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+1 −1
Review log 1824
-
Josua Vogel uploaded patch set 1 03/14/26, 15:17
-
core-ci voted on patch set 1 V +1 03/14/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97946
-
Benjamin Franzke rebased onto patch set 2
V +103/18/26, 05:06 -
core-ci voted on patch set 2 V +1 03/18/26, 05:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98133
-
Josua Vogel rebased onto patch set 3
V +103/18/26, 11:07 -
core-ci voted on patch set 3 V +1 03/18/26, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98166
-
Benjamin Franzke commented on patch set 3 CR -1 03/18/26, 12:07
-
Josua Vogel uploaded patch set 4
CR -1V +103/18/26, 12:25 -
Josua Vogel commented on patch set 4 03/18/26, 12:25
stage-component.ts:179ReplyDone -
core-ci voted on patch set 4 V -1 03/18/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98182
-
core-ci voted on patch set 4 V +1 03/18/26, 12:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98182
-
Benjamin Franzke commented on patch set 4 V -1 03/19/26, 07:41
stage-component.ts:179Using the first element only, causes template parts that contain multiple elements to be cropped. e.g. given the following example: ``` <template> <h2>…</h2> <div>…</div> </template ``` Only `h2` would be selected and `div` ignored. (I found at least one usecase with the linked checkbox extension) I'll fix. -
Benjamin Franzke uploaded patch set 5
V +103/19/26, 08:13 -
Benjamin Franzke commented on patch set 5 03/19/26, 08:13
stage-component.ts:179ReplyDone -
Benjamin Franzke voted on patch set 5 CR +1 V +1 03/19/26, 08:13
-
core-ci voted on patch set 5 V +1 03/19/26, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98226
-
Andreas Kienast commented on patch set 5 03/19/26, 09:37
Several exported functions in stage-component.ts are considered unused (were already before this patch). Are those left-overs or kept for bc reasons?stage-component.ts:1044Would it make sense to officially deprecate this, or is this planned for another patch? -
Josua Vogel commented on patch set 5 03/19/26, 09:52
stage-component.ts:1044ReplyYes, I want to deprecate those functions in a separate patch 😊 -
Benjamin Franzke commented on patch set 5 03/19/26, 09:52
stage-component.ts:1044ReplyCan you name them? Maybe the IDE is confused by constructs like ``` import * as StageComponent from '@typo3/form/backend/form-editor/stage-component'; // … export function getStage(): typeof StageComponent { return stageComponent; } // … getStage().getStagePanelDomElement() ``` So that the usage (in this case of `getStagePanelDomElement()`) is not tracked? -
Benjamin Franzke commented on patch set 5 03/19/26, 09:53
stage-component.ts:1044Replyah, ok, Josua already confirmed. -
Josua Vogel commented on patch set 5 03/19/26, 09:59
stage-component.ts:1044ReplyYes, most render functions should be deprecated, because I introduced a web component. Extensions might use those methods, so we need to deprecate them. Those extensions can use the web component or implement a custom rendering. But I would do this in a separate patch -
Josua Vogel commented on patch set 5 03/20/26, 06:42
stage-component.ts:1044Replyresolve -
Andreas Kienast voted on patch set 5 CR +2 V +2 03/20/26, 08:37
-
Andreas Kienast merged patch set 6 03/20/26, 08:37
stage-component.ts:179