Review TYPO3_4-6 Merged

9319[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain

Wouter Wolters CR +2 V +2 Easy +17 −9 updated 06/03/13, 20:49

Commit message

If the TYPO3 BE host name is not configured as a sys_domain record
t3lib_BEfunc::getViewDomain() will always return TYPO3 BE host name
and not the first domain of the root line of the page which is
being previewed.

Furthermore, if the TYPO3 BE host name is configured as a sys_domain
but the current root line does not contain a valid domain record,
t3lib_BEfunc::getViewDomain() will return only 'http://' ie. no domain.

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Files 1

Review log 7

  1. Susi Moog uploaded patch set 2 03/06/12, 09:14

  2. Susi Moog uploaded patch set 3 03/06/12, 09:14

  3. Susi Moog commented on patch set 3 03/06/12, 09:14

    Verified; Looks good to me, but someone else must approve
  4. Xavier Perseguers uploaded patch set 4 03/06/12, 09:14

  5. Xavier Perseguers commented on patch set 4 V 0 03/06/12, 09:14

    by team member; Looks good to me, approved Was properly reviewed, just removed the useless dependency on a backport branch patch
  6. Georg Ringer commented on patch set 3 03/06/12, 09:14

    Verified; Looks good to me, but someone else must approve
  7. Xavier Perseguers merged patch set 4 03/06/12, 09:14