93191[TASK] Integrate virtual app package into package manager
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Garvin Hicking +1
- Simon Praetorius +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Helmut Hummel +2
- Garvin Hicking +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 19
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+4 −1
- typo3/sysext/core/Classes/Composer/PackageArtifactBuilder.php+9 −0
- typo3/sysext/core/Classes/Core/Environment.php+4 −2
- typo3/sysext/core/Classes/Localization/LanguagePackService.php+4 −1
- typo3/sysext/core/Classes/Package/Cache/PackageCacheEntry.php+6 −0
- typo3/sysext/core/Classes/Package/Cache/PackageCacheInterface.php+3 −0
- typo3/sysext/core/Classes/Package/Resource/ResourceCollection.php+19 −21
- typo3/sysext/core/Classes/Package/Resource/ResourceCollectionInterface.php+4 −4
- typo3/sysext/core/Classes/Package/Package.php+9 −4
- typo3/sysext/core/Classes/Package/PackageManager.php2+23 −11
- typo3/sysext/core/Classes/Package/VirtualAppPackage.php2new+47 −0
- typo3/sysext/core/Classes/SystemResource/Identifier/SystemResourceIdentifierFactory.php+2 −6
- typo3/sysext/core/Classes/SystemResource/Package/AppResourceCollection.phprenamed+4 −5
- typo3/sysext/core/Classes/SystemResource/Package/VirtualAppPackage.phpdeleted+0 −43
- typo3/sysext/core/Classes/SystemResource/SystemResourceFactory.php+1 −1
- typo3/sysext/core/Classes/ServiceProvider.php+2 −0
- typo3/sysext/core/Tests/Unit/SystemResource/Identifier/SystemResourceIdentifierFactoryTest.php+7 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+5 −1
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php+9 −1
Review log 1114
-
Helmut Hummel uploaded patch set 1 03/14/26, 20:59
-
core-ci voted on patch set 1 V -1 03/14/26, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97950
-
Helmut Hummel uploaded patch set 2
V -103/15/26, 09:14 -
core-ci voted on patch set 2 V -1 03/15/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97967
-
Helmut Hummel uploaded patch set 3
V -103/15/26, 11:20 -
core-ci voted on patch set 3 V +1 03/15/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97969
-
Garvin Hicking voted on patch set 3 CR +1 V +1 03/15/26, 13:08
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 03/15/26, 15:48
-
Simon Praetorius commented on patch set 3 03/16/26, 08:42
VirtualAppPackage.php:29Do you expect this constant to be private before LTS? In the current code, it's a bit confusing to me that the class itself requires the package key in the constructor, which is always read from that constant. If there will be that special package for the foreseeable future, maybe a factory method could be added here instead of exposing that constant? -
Helmut Hummel commented on patch set 3 03/16/26, 08:52
PackageManager.php:646Replyit should only exclude the app packageVirtualAppPackage.php:29Replythanks! this https://github.com/TYPO3/typo3/blob/73bf21179167d2a5cec4f2729e4d3be7360a029d/typo3/sysext/core/Classes/SystemResource/SystemResourceFactory.php#L127 is the only usage, that can not be resolved in other ways. It is in a code path, that is not yet deprecated, but soon will be and will then naturally vanish. We could argue, that we can hard code the value there as this code will vanish anyway at some point. will take that into consideration when making public resources configurable -
Simon Praetorius voted on patch set 3 CR +1 03/16/26, 08:54
-
Helmut Hummel voted on patch set 3 CR +2 V +2 03/16/26, 09:18
-
Helmut Hummel merged patch set 4 03/16/26, 09:18
-
Helmut Hummel wrote 03/16/26, 12:59
Created a revert of this change as Ic446cc1d1b7cc82d43f049f84d0030b381493a98
PackageManager.php:646