Review main Merged

93191[TASK] Integrate virtual app package into package manager

Helmut Hummel CR +2 V +2 Hard +162 −101 updated 03/16/26, 12:59

Commit message

In order to allow TYPO3 code and configuration
to reference resources in the typo3/app package
the system resource API introduced a virtual app package,
which was instantiated on the fly
when resolving system resources.

This clunky workaround can be cleaned up, by integrating this
package into the package manager as (almost) regular package.

The package can be now discovered by the package manager,
but is still hidden from active packages by default.

By doing so, all package resources can be cached alongside
the package itself, which for now isn't a big deal,
but at least avoids some lookups regarding the extension
icons.

This is a preparatory change to also allow arbitrary public
resources to be configured for extensions and the app
package, which will be an important requirement
for theme overrides without the need to create an extension.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Garvin Hicking +1
    • Simon Praetorius +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1114

  1. Helmut Hummel uploaded patch set 1 03/14/26, 20:59

  2. core-ci voted on patch set 1 V -1 03/14/26, 21:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97950

  3. Helmut Hummel uploaded patch set 2 V -1 03/15/26, 09:14

  4. core-ci voted on patch set 2 V -1 03/15/26, 09:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97967

  5. Helmut Hummel uploaded patch set 3 V -1 03/15/26, 11:20

  6. core-ci voted on patch set 3 V +1 03/15/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97969

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 03/15/26, 13:08

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 03/15/26, 15:48

  9. Simon Praetorius commented on patch set 3 03/16/26, 08:42

    PackageManager.php:646

    Shouldn't this be done based on the class name with `instanceof`? Or should the parameter only exclude the one app package and not all virtual packages?

    VirtualAppPackage.php:29

    Do you expect this constant to be private before LTS? In the current code, it's a bit confusing to me that the class itself requires the package key in the constructor, which is always read from that constant. If there will be that special package for the foreseeable future, maybe a factory method could be added here instead of exposing that constant?
  10. Helmut Hummel commented on patch set 3 03/16/26, 08:52

    PackageManager.php:646 Reply

    it should only exclude the app package

    VirtualAppPackage.php:29 Reply

    thanks! this https://github.com/TYPO3/typo3/blob/73bf21179167d2a5cec4f2729e4d3be7360a029d/typo3/sysext/core/Classes/SystemResource/SystemResourceFactory.php#L127 is the only usage, that can not be resolved in other ways. It is in a code path, that is not yet deprecated, but soon will be and will then naturally vanish. We could argue, that we can hard code the value there as this code will vanish anyway at some point. will take that into consideration when making public resources configurable
  11. Simon Praetorius voted on patch set 3 CR +1 03/16/26, 08:54

  12. Helmut Hummel voted on patch set 3 CR +2 V +2 03/16/26, 09:18

  13. Helmut Hummel merged patch set 4 03/16/26, 09:18

  14. Helmut Hummel wrote 03/16/26, 12:59

    Created a revert of this change as Ic446cc1d1b7cc82d43f049f84d0030b381493a98