93195[TASK] Improve writing styles of "Configuration Presets" descriptions
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Lina Wolf +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Lina Wolf +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Cache.fluid.html5+25 −16
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Context.fluid.html+12 −6
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Image.fluid.html2+9 −9
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/Mail.fluid.html+8 −6
- typo3/sysext/install/Resources/Private/Partials/Settings/Presets/PasswordHashing.fluid.html+10 −7
- typo3/sysext/install/Resources/Private/Templates/Settings/PresetsGetContent.fluid.html+7 −3
Review log 1620
-
Riccardo De Contardi uploaded patch set 1 03/15/26, 16:59
-
core-ci voted on patch set 1 V +1 03/15/26, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97971
-
Garvin Hicking commented on patch set 1 03/27/26, 08:22
Reads reasonable to me! 😊 Maybe optimize linerbeaks?Cache.fluid.html:29Add HTML linebreaks here, like they are in plaintext?Image.fluid.html:29linebreaks here too? -
Riccardo De Contardi commented on patch set 2
V +103/27/26, 08:30Published edit on patch set 1. -
Riccardo De Contardi commented on patch set 2 03/27/26, 08:31
Tried to wrap the lines at around 100charsCache.fluid.html:29ReplyDoneImage.fluid.html:29ReplyDone -
core-ci voted on patch set 2 V -1 03/27/26, 08:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98841
-
Garvin Hicking commented on patch set 2 03/27/26, 08:50
Cache.fluid.html:29ReplyI meant <br> for new paragraphs. Or use more <p> parsgraphs. Its not about line wrapping but logical paragraphs as they appear here with \n -
Riccardo De Contardi commented on patch set 3
V -103/27/26, 08:56Published edit on patch set 2. -
Riccardo De Contardi commented on patch set 3 03/27/26, 08:56
Cache.fluid.html:29ReplyOh I see, lemme fix the stuff CI is complaining and I'll send a new patch -
Riccardo De Contardi commented on patch set 3 03/27/26, 08:56
a new patch will followCache.fluid.html:29ReplyDone -
core-ci voted on patch set 3 V +1 03/27/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98844
-
Riccardo De Contardi uploaded patch set 4
V +103/27/26, 11:59 -
core-ci voted on patch set 4 V +1 03/27/26, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98860
-
Garvin Hicking commented on patch set 4 03/27/26, 13:27
Reply
In the other files like cache.fluid.html I still see some paragraph opportunities - are you still on it? -
Riccardo De Contardi commented on patch set 4 03/27/26, 13:59
Reply
Please look at patchset 4, tx.with the latest patchset I tried to avoid the "wall-o-text" effect without occupying too much space. -
Garvin Hicking voted on patch set 4 CR +1 V +1 03/27/26, 15:08
-
Lina Wolf commented on patch set 4 CR +1 V +1 04/06/26, 06:31
Tested it and it looks good, code looks good to me -
Oliver Klee voted on patch set 4 CR +1 V +1 04/06/26, 08:30
-
Garvin Hicking voted on patch set 4 CR +2 V +2 04/06/26, 08:39
-
Garvin Hicking merged patch set 5 04/06/26, 08:39