93204[TASK] Add CI checks for commit message
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 1
Review log 67
-
Garvin Hicking uploaded patch set 1 03/16/26, 12:00
-
core-ci voted on patch set 1 V -1 03/16/26, 12:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98014
-
Stefan Bürk commented on patch set 1 03/16/26, 12:38
General: * Create a dedicated script for all the checks we want to have for it. * Script should be standalone executable or better through runTests.sh * I would abstain from making the 72char length restriction for the subject line, mainly because wie already have a "except" for that and the line length stated in rules and it is casually exceeded (albeit not heavily). I would omit a CI length check at all. -
Garvin Hicking commented on patch set 1 03/16/26, 12:39
Unresolved
OK this fails because `git` is not an available CLI tool on the machine. I need help 😄 -
Garvin Hicking commented on patch set 1 03/16/26, 12:55
Reply Unresolved
I would argue this is a single check, so a single script. I don't think the 5 steps should be isolated from each other, they belong together and are kind of alternating...? Can runTests.sh scripts access the git commit message? How? In which cases do we subjects that may be larger than that? I thought this is a hard rule? I think I'd need more on this, I won't be able to pursue this on my own. But it's not that critical - only that we recently had 4 commits that failed these checks. -
Benni Mack marked it work in progress 04/21/26, 15:16
-
Garvin Hicking abandoned the change 04/22/26, 07:17
no interest from others