Review main Merged

93209[BUGFIX] Process command map in ContextualRecordEditController

Benjamin Kott CR +2 V +2 Easy +2 −1 updated 03/16/26, 19:09

Commit message

The contextual record edit panel silently ignored delete operations
on inline records (e.g. file references) because the DataHandler
was never given the `cmd` map from the form submission, and
`process_cmdmap()` was never called.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Benjamin Kott uploaded patch set 1 03/16/26, 18:57

  2. core-ci voted on patch set 1 V +1 03/16/26, 19:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98041

  3. Oli Bartsch commented on patch set 1 CR +1 V +1 03/16/26, 19:09

    Thanks a lot. Seems I overlooked this use case, as I focused on keeping the controller as lightweight as possible and only including the data processing functionality that is strictly needed for editing existing records.
  4. Benni Mack voted on patch set 1 CR +2 V +2 03/16/26, 19:09

  5. Benni Mack merged patch set 2 03/16/26, 19:09